ENH: Logistic completeness function

skypyproject / skypy

SkyPy: A package for modelling the Universe.

BSD 3-Clause "New" or "Revised" License

117 stars 38 forks source link

ENH: Logistic completeness function #521

Closed philipp128 closed 2 years ago

philipp128 commented 2 years ago

Description

This PR adds a feature to calculate the logistic completeness function. Closes #519.

Checklist

[x] Follow the Contributor Guidelines
[x] Write unit tests
[x] Write documentation strings
[x] Assign someone from your working team to review this pull request
[x] Assign someone from the infrastructure team to review this pull request

philipp128 commented 2 years ago

Edit: It works now and the docs should be fine.

~~Docs are failing. I am waiting to resolve this right now cause I have a problem with the docs anyway.~~

~~The docs for completeness function is not rendered properly. It is included but not linked or specified -> see attached~~ ~~image. I do not know where the problem is.~~

~~@rrjbca do you know whether I forgot sth?~~

rrjbca commented 2 years ago

I would also suggest making this part of skypy.utils.photometry. In effect the completeness is an extrinsic photometric property of the sources. This would again save creating a new submodule.