Closed philipp128 closed 2 years ago
This is intended. Unlike varying m_star, each different value of alpha requires constructing a different CDF and we couldn't come up with an efficient way around this. You could add the dependent_argument
decorator for consistency and to allow functions for alpha that return a single scalar value. However, I expect an implementation varying alpha for each galaxy would be non-trivial.
@rrjbca true I remember our discussion now. I think we should then at least change the requirement of alpha
in the docs of schechter_lf
and schechter_smf
to alpha
being a scalar. Or that we enable a callable that returns a scalar value.
I prefer the first.
What do you think?
I would suggest adding the @dependent_argument
decorator to make it consistent with schechter_lf_magnitude
Ok as we discussed it is intended so I close this issue.
Description
The input parameter
alpha
(here) of the methodschechter_smf_mass
inskypy.galaxies.stellar_mass
should be allowed to be an array_like or callable parameter.This is especially correlated to the method
schechter_smf
inskypy.galaxies._schechter
(here) wherealpha
is allowed to be array_like and callable and used to callschechter_smf_mass
.