ENH: Rykoff model of the magnitude uncertainty

skypyproject / skypy

SkyPy: A package for modelling the Universe.

BSD 3-Clause "New" or "Revised" License

117 stars 38 forks source link

ENH: Rykoff model of the magnitude uncertainty #526

Closed philipp128 closed 2 years ago

philipp128 commented 2 years ago

Description

This PR adds a feature to calculate the magnitude uncertainty following the model of Rykoff et al. (2015). Closes #517.

Checklist

[x] Follow the Contributor Guidelines
[x] Write unit tests
[x] Write documentation strings
[x] Assign someone from your working team to review this pull request
[x] Assign someone from the infrastructure team to review this pull request

philipp128 commented 2 years ago

I think this should go in skypy.utils.photometry. I looked over the paper quickly and don't think anything in the model is specific to galaxies. This would save having to create an additional super-specific submodule.

@rrjbca hmm yeah. I'll change it. I initially added it to the galaxy module as Rykoff et al. explicitly mention galaxies while deriving the equation. However, it should not be dependent on the object type but solely survey dependent.

philipp128 commented 2 years ago

Looks good. Really like the extra analytic case for the unit tests. Just spotted a couple of very small things I'll address myself quickly...

Perfect. Thanks a lot :)