skypyproject / skypy

SkyPy: A package for modelling the Universe.
BSD 3-Clause "New" or "Revised" License
117 stars 38 forks source link

ENH: Adding model for Dust extincted ellipticity projection #549

Closed jucordero closed 1 year ago

jucordero commented 2 years ago

Description

Implements an achromatic model for dust obscured ellipticity distributions, from Padilla & Strauss 2008. This would close #341

The model follows a similar structure to ryden04_ellipticity. The dust_extincted_ellipticity samples axis ratios and projects the resultant 3D ellipsoid using Binney formulation in triaxial_axis_ratio_extincted. Here, instead of sampling from a uniform cosine distribution for the inclination angle, extincted_angle_schechter is called to sample a random orientation assuming a Schechter luminosity function and the dust model.

Luminosity function parameters are assumed fixed (i.e. not arrays), which simplifies the broadcasting to get the sample size right, and also fits a more realistic use case.

Checklist

jucordero commented 2 years ago

I've added a notebook with some detailed explanation of how the functions are built in this enhancement to the projected-ellipticity repository (private)

https://github.com/skypyproject/projected-ellipticities/blob/master/Dust-extincted%20ellipticity%20model.ipynb

I'm not sure the unit tests I added are completely appropriate. Suggestions appreciated.

jucordero commented 1 year ago

Just had a chat at the SkyPy meeting. In essencem, this PR models ellipticity as a function of extinction, while what we really want is a model for extinction as a function of ellipticity, which is a much simpler task. We've also discussed about the possibility that extinction as a function of ellipticity could interfere with the k-correction templates.