Closed rrjbca closed 8 months ago
The compatibility workflow is currently failing for the astropy development version with ImportError: cannot import name 'update_default_config' from 'astropy.config.configuration' : https://github.com/skypyproject/skypy/actions/runs/6681172883/job/18155043088#step:6:117
ImportError: cannot import name 'update_default_config' from 'astropy.config.configuration'
update_default_config was deprected in astropy 5.0 and was recently removed on the main branch in preparation for 6.0: https://github.com/astropy/astropy/pull/15466
update_default_config
This PR updates _astropy_init.py to match the latest version in astropy package-template which no longer requires update_default_config: https://github.com/astropy/package-template/blob/cookiecutter/%7B%7B%20cookiecutter.package_name%20%7D%7D/%7B%7B%20cookiecutter.module_name%20%7D%7D/_%7B%7B%20cookiecutter._parent_project%20%7D%7D_init.py
This patch has been demonstrated to resolve the issue on with the compatibility workflow here: https://github.com/rrjbca/skypy/actions/runs/6682165049/job/18157042681
Once approved I can also backport to v0.5.x and make a release v0.5.3 which will be necessary for the compatibility workflow "latest" job to pass.
Description
The compatibility workflow is currently failing for the astropy development version with
ImportError: cannot import name 'update_default_config' from 'astropy.config.configuration': https://github.com/skypyproject/skypy/actions/runs/6681172883/job/18155043088#step:6:117update_default_configwas deprected in astropy 5.0 and was recently removed on the main branch in preparation for 6.0: https://github.com/astropy/astropy/pull/15466This PR updates _astropy_init.py to match the latest version in astropy package-template which no longer requires
update_default_config: https://github.com/astropy/package-template/blob/cookiecutter/%7B%7B%20cookiecutter.package_name%20%7D%7D/%7B%7B%20cookiecutter.module_name%20%7D%7D/_%7B%7B%20cookiecutter._parent_project%20%7D%7D_init.pyThis patch has been demonstrated to resolve the issue on with the compatibility workflow here: https://github.com/rrjbca/skypy/actions/runs/6682165049/job/18157042681
Once approved I can also backport to v0.5.x and make a release v0.5.3 which will be necessary for the compatibility workflow "latest" job to pass.
Checklist