search

skyra-project / discord-components

Discord Webcomponents for real looking messages on the web
MIT License
244 stars 31 forks source link

feat!: rewrite to lit #367

Closed favna closed 5 months ago

favna commented 11 months ago

TODO taken from #337

Something weird is happening with ephemeral replies. I can't quite find out what and why: image

Also in non ephemeral with compact mode the text doesn't center out correctly with the username: image

Some things I am noticing that I'd just like to drop here:

  1. Kinda mentioned it before but there are some wacky things with compact mode. Outlining, font sizes, etc.

  2. The icon for channel mentions isn't properly aligned. image. I can't tell for sure myself but I also think the other mention SVGs are slightly misaligned.

  3. DiscordLink doesn't use the consumer for lightTheme yet

  4. Update all codesandbox links (post releasing alpha version)

  5. Add Svelte and Sveltekit codesandbox links

Will probably edit this message as I progress further writing unit tests

Lulalaby commented 10 months ago

Members is not a mentionable and won't become one in near future, because it's an tab only moderators+ can see. So might not be worth adding.

favna commented 10 months ago

Members is not a mentionable and won't become one in near future, because it's an tab only moderators+ can see. So might not be worth adding.

Good point. We can skip it for now.

Lulalaby commented 10 months ago

Imma lyk if it changes

favna commented 10 months ago

Finished rebasing the branch so it's clean to work in again