skyrim-multiplayer / skymp

Multiplayer Mod & TypeScript SDK for Skyrim Special Edition
Other
217 stars 75 forks source link

Sync Devs Checkout List #198

Closed Pospelove closed 2 years ago

Pospelove commented 3 years ago

Before You Start

  1. Use Google Translate to translate sentences you do not understand.
  2. Read task group headers in root tasks:

    Read me please

    Read me also, please

    • [ ] task 1
    • [ ] task 2
  3. Read the info and useful things at the bottom of the issue.
  4. Ask @SupAidmi to assign a task to you (we normally use Discord)

Picking Up Tasks

Working On The Task

  1. Create a Draft Pull Request immediately. Write closes #<your issue number here> to the description. This allows us to track tasks. You can create a Draft Pull Request that changes only one line and finish it later.
  2. Write code. Push to your branch.
  3. Convert Draft PR into normal.
  4. Wait for the review.

Common Tips

How To Code Sync

Search for these files/identifiers:

How To Test Sync

Being Brave

You will see confusing code:

When you are doing your task, you are the owner of your code. Do everything you can do to get it to work. We would be able to talk about style during the review. Bring the moment of review closer.

If there is a bug or everything that prevents you from doing your task, you can fix it right now. It would be accepted with your PR.

Pospelove commented 2 years ago

We do not use this manual currently so closing for now