search

skyrim-multiplayer / skymp

Multiplayer Mod & TypeScript SDK for Skyrim Special Edition
Other
220 stars 74 forks source link

Review and fix SP event typings #270

Open Pospelove opened 3 years ago

Pospelove commented 3 years ago

Event types always contain non-null object types. This is not always true. At least ContainerChangedEvent.reference should be ObjectReference | null.

https://github.com/skyrim-multiplayer/skymp/blob/2164caed940a3b0d17e7b9815d436d3afa3511a9/skyrim-platform/src/platform_se/codegen/convert-files/Definitions.txt#L194

FredericoGauz commented 3 years ago

This is not directly related to the issue but seemed to be a good place to ask.

If I add comments to this file, will they be carried on to the generated skyrimPlatform.ts?

I don't understand very well these papyrus functions and would be handy to document them here and have nice information about these functions when using them.

I was going to add them on my side, but since this file is generated I didn't want to lose any progress I might make.

Pospelove commented 3 years ago

@FredericoGauz Do you take info from CK wiki?