search

skysafe / gr-sigmf

GNURadio blocks to read, write, and modify SigMF datasets
Other
30 stars 11 forks source link

Namespace Conflict with Official SigMF #25

Closed Teque5 closed 5 years ago

Teque5 commented 5 years ago

A few of us are working on additions to the official SigMF python package.

We also use gr-sigmf and the namespace conflict for import sigmf yeilds :frowning:, since both this package and the official installer use sigmf.

I know changing namespace in GNU Radio modules is a pain, but we think that the official sigmf repo shouldn't have to change.

storborg commented 5 years ago

Agreed, that conflict is a problem, and the official sigmf repo shouldn't have to change. Thanks for bringing this up.

The logical thing to do is maybe to rename the Python package to something like gr_sigmf. The question is, which is worse: breaking convention with typical OOT modules? Or renaming the whole OOT module to something like gr-sigmf-io?

We will consider this our responsibility to solve, but if you have any suggestions, they are very welcome.

pwicks86 commented 5 years ago

gr-sigmf-io works for me.

pwicks86 commented 5 years ago

We ended up going with gr_sigmf. See d03774a1328a2217b5ddd3fdde2419c1c8cf241e

Teque5 commented 5 years ago

I tested d03774a and it works in python2 interpreter, but grc is still trying to import sigmf instead of import gr_sigmf when I use a SigMF Source block.

pwicks86 commented 5 years ago

Ah, oops.. thanks for trying it out. I'll fix that momentarily.

pwicks86 commented 5 years ago

Should be fixed now.

Teque5 commented 5 years ago

Yup; looks good, closing issue. Thanks folks.