Fix type for subsecond duration in SigMF sink

skysafe / gr-sigmf

GNURadio blocks to read, write, and modify SigMF datasets

Other

30 stars 11 forks source link

Fix type for subsecond duration in SigMF sink #32

Closed docprofsky closed 5 years ago

docprofsky commented 5 years ago

This fixes a bug that I introduced in #30. The type for the subsecond duration should be signed. The duration can become negative when there are buffer overruns.

storborg commented 5 years ago

I haven't tried to reproduce this, but I think that this line: https://github.com/skysafe/gr-sigmf/blob/d3f34442d0861579b2ac23276ffc14fbfa72ab2b/lib/sink_impl.cc#L697 Should guarantee that doesn't happen?

docprofsky commented 5 years ago

So, I thought I remembered this causing problems for me and doing this to fix it around last month. (I was updating gr-sigmf when I noticed I had not committed the changes) But I now am unable to reproduce it, so I think it is fixed or was not the problem.

storborg commented 5 years ago

Oh ok, I think we may have pushed that change more recently. Thanks for looking at it!