search

skyscreamer / yoga

Yoga is RESTful but flexible.
http://yoga.skyscreamer.org/
Apache License 2.0
156 stars 66 forks source link

Added null check to type discovery in MetaDataRegistry #226

Closed cepage closed 11 years ago

sduskis commented 11 years ago

Was there some error condition that triggered this change? If so, we probably should cover that case

cepage commented 11 years ago

Yes, if the readMethod returns an untyped iterable:

public List getCustomers()

then getCollectionType returns null, and the addFields method crashes.

On Tue, Aug 20, 2013 at 7:59 PM, Solomon Duskis notifications@github.comwrote:

Was there some error condition that triggered this change? If so, we probably should cover that case

— Reply to this email directly or view it on GitHubhttps://github.com/skyscreamer/yoga/pull/226#issuecomment-22989030 .

sduskis commented 11 years ago

So shouldn't we be handling that case by producing something (tbd) instead of nothing?

cepage commented 11 years ago

Yes, let's discuss during call

On Tuesday, August 20, 2013, Solomon Duskis wrote:

So shouldn't we be handling that case by producing something (tbd) instead of nothing?

— Reply to this email directly or view it on GitHubhttps://github.com/skyscreamer/yoga/pull/226#issuecomment-22989340 .