skytap / terraform-provider-skytap

Terraform Skytap provider
https://www.terraform.io/docs/providers/skytap/
Mozilla Public License 2.0
4 stars 11 forks source link

Documentation: published service attribute external_id -> external_ip #4

Closed ja6a closed 5 years ago

ja6a commented 5 years ago

Documentation reads external_id for an attribute on published service, describing it as an external ID, it is, in fact external_ip representing the published service's external IP.

jchenry commented 5 years ago

I am concerned about using the internal IP as the key, since technically, this could be dynamically assigned and not specified.

ideally, an interpolation to get to the attributes would be in a more direct way, i.e. skytap_vm.my_vm.network_interface.eth0.published_service.ssh

and expressed as a resource:

resource "skytap_vm" "vm2" {
   network_interface "eth0" {
 ...
    published_service "ssh" {
      "internal_port" = 22
    }
  }

I'm unsure if this is acheivable. I'm sure other approaches would work as well.

ja6a commented 5 years ago

I am concerned about using the internal IP as the key, since technically, this could be dynamically assigned and not specified.

ideally, an interpolation to get to the attributes would be in a more direct way, i.e. skytap_vm.my_vm.network_interface.eth0.published_service.ssh

and expressed as a resource:

resource "skytap_vm" "vm2" {
   network_interface "eth0" {
 ...
    published_service "ssh" {
      "internal_port" = 22
    }
  }

I'm unsure if this is acheivable. I'm sure other approaches would work as well.

I think this comment belongs here: #7

ja6a commented 5 years ago

Resolved in PR #8