Closed matpimenta closed 4 years ago
Updating the skytap-sdk-go to fix
I've also updated the acceptance tests to fix a missing template and to make it less flaky
Acceptance Test runs ? github.com/terraform-providers/terraform-provider-skytap [no test files] === RUN TestUserAgent 2020/04/16 10:46:35 [DEBUG] user agent version (version.go): 0.12.1 2020/04/16 10:46:35 [DEBUG] user agent version (version.go): 0.12.1 --- PASS: TestUserAgent (0.00s) === RUN TestAccDataSourceSkytapProject_Basic === PAUSE TestAccDataSourceSkytapProject_Basic === RUN TestAccDataSourceSkytapTemplate_Basic === PAUSE TestAccDataSourceSkytapTemplate_Basic === RUN TestAccDataSourceSkytapTemplate_RegexMostRecent === PAUSE TestAccDataSourceSkytapTemplate_RegexMostRecent === RUN TestProvider --- PASS: TestProvider (0.00s) === RUN TestProvider_impl --- PASS: TestProvider_impl (0.00s) === RUN TestAccSkytapLabelCategory_Basic --- PASS: TestAccSkytapLabelCategory_Basic (4.43s) === RUN TestAccSkytapLabelCategory_Update --- PASS: TestAccSkytapLabelCategory_Update (4.91s) === RUN TestAccSkytapLabelCategory_MultiValueBasic --- PASS: TestAccSkytapLabelCategory_MultiValueBasic (7.05s) === RUN TestAccSkytapLabelCategory_Duplicated --- PASS: TestAccSkytapLabelCategory_Duplicated (3.39s) === RUN TestAccSkytapEnvironment_Basic --- PASS: TestAccSkytapEnvironment_Basic (106.61s) === RUN TestAccSkytapEnvironment_UpdateTemplate --- PASS: TestAccSkytapEnvironment_UpdateTemplate (236.82s) === RUN TestAccSkytapEnvironment_UpdateTags --- PASS: TestAccSkytapEnvironment_UpdateTags (108.50s) === RUN TestAccSkytapEnvironment_UserData --- PASS: TestAccSkytapEnvironment_UserData (94.39s) === RUN TestAccSkytapEnvironment_UserDataUpdate --- PASS: TestAccSkytapEnvironment_UserDataUpdate (134.47s) === RUN TestAccSkytapEnvironment_Labels --- PASS: TestAccSkytapEnvironment_Labels (147.95s) === RUN TestAccSkytapEnvironment_LabelsUpdate --- PASS: TestAccSkytapEnvironment_LabelsUpdate (142.36s) === RUN TestAccSkytapLabelICNR_Basic --- PASS: TestAccSkytapLabelICNR_Basic (156.50s) === RUN TestAccSkytapNetwork_Basic === PAUSE TestAccSkytapNetwork_Basic === RUN TestAccSkytapNetwork_Update === PAUSE TestAccSkytapNetwork_Update === RUN TestAccSkytapProject_Basic === PAUSE TestAccSkytapProject_Basic === RUN TestAccSkytapVM_Basic --- PASS: TestAccSkytapVM_Basic (290.32s) === RUN TestAccSkytapVM_Timeout --- PASS: TestAccSkytapVM_Timeout (286.86s) === RUN TestAccSkytapVM_Update --- PASS: TestAccSkytapVM_Update (425.72s) === RUN TestAccSkytapVM_Interface --- PASS: TestAccSkytapVM_Interface (805.50s) === RUN TestAccSkytapVM_PublishedService --- PASS: TestAccSkytapVM_PublishedService (973.21s) === RUN TestAccSkytapVM_PublishedServiceBadNic --- PASS: TestAccSkytapVM_PublishedServiceBadNic (194.39s) === RUN TestAccExternalPorts --- PASS: TestAccExternalPorts (416.89s) === RUN TestAccSkytapVM_Typical --- PASS: TestAccSkytapVM_Typical (607.27s) === RUN TestAccSkytapVMCPURam_Create --- PASS: TestAccSkytapVMCPURam_Create (775.32s) === RUN TestAccSkytapVMCPU_DiskIntact --- FAIL: TestAccSkytapVMCPU_DiskIntact (892.29s) === RUN TestAccSkytapVMCPURAM_UpdateNPECheck --- PASS: TestAccSkytapVMCPURAM_UpdateNPECheck (450.22s) === RUN TestAccSkytapVMCPURAM_Invalid --- PASS: TestAccSkytapVMCPURAM_Invalid (0.01s) === RUN TestAccSkytapVMCPU_OutOfRange --- PASS: TestAccSkytapVMCPU_OutOfRange (153.18s) === RUN TestAccSkytapVMCPU_OutOfRangeAfterUpdate --- PASS: TestAccSkytapVMCPU_OutOfRangeAfterUpdate (271.20s) === RUN TestAccSkytapVMDisks_Create --- PASS: TestAccSkytapVMDisks_Create (515.54s) === RUN TestAccSkytapVMDisks_UpdateNPECheck --- PASS: TestAccSkytapVMDisks_UpdateNPECheck (421.14s) === RUN TestAccSkytapVMDisks_Resize --- PASS: TestAccSkytapVMDisks_Resize (477.53s) === RUN TestAccSkytapVMDisk_Invalid --- PASS: TestAccSkytapVMDisk_Invalid (0.01s) === RUN TestAccSkytapVMDisk_OS --- PASS: TestAccSkytapVMDisk_OS (459.54s) === RUN TestAccSkytapVMDisk_OSChangeAfter --- PASS: TestAccSkytapVMDisk_OSChangeAfter (447.88s) === RUN TestAccSkytapVM_Concurrent --- FAIL: TestAccSkytapVM_Concurrent (704.14s) === RUN TestAccSkytapVM_UserData --- FAIL: TestAccSkytapVM_UserData (413.16s) === RUN TestAccSkytapVM_Labels --- FAIL: TestAccSkytapVM_Labels (19.31s) === RUN TestFlattenInterfaces --- PASS: TestFlattenInterfaces (0.00s) === RUN TestFlattenPublishedServices --- PASS: TestFlattenPublishedServices (0.00s) === RUN TestFlattenDisks --- PASS: TestFlattenDisks (0.00s) === RUN TestValidateNICType --- PASS: TestValidateNICType (0.00s) === RUN TestValidateRoleType --- PASS: TestValidateRoleType (0.00s) === RUN TestValidateNoSubString --- PASS: TestValidateNoSubString (0.00s) === RUN TestValidateNoStartWith --- PASS: TestValidateNoStartWith (0.00s) === CONT TestAccDataSourceSkytapProject_Basic === CONT TestAccSkytapNetwork_Update --- FAIL: TestAccDataSourceSkytapProject_Basic (88.27s) === CONT TestAccSkytapProject_Basic --- FAIL: TestAccSkytapProject_Basic (15.32s) === CONT TestAccDataSourceSkytapTemplate_RegexMostRecent --- PASS: TestAccDataSourceSkytapTemplate_RegexMostRecent (149.43s) === CONT TestAccSkytapNetwork_Basic --- PASS: TestAccSkytapNetwork_Update (427.14s) === CONT TestAccDataSourceSkytapTemplate_Basic --- PASS: TestAccDataSourceSkytapTemplate_Basic (10.56s) --- FAIL: TestAccSkytapNetwork_Basic (259.14s) FAIL FAIL github.com/terraform-providers/terraform-provider-skytap/skytap 11660.513s === RUN TestResponseErrorIsNotFound_BadRequest --- PASS: TestResponseErrorIsNotFound_BadRequest (0.00s) === RUN TestResponseErrorIsNotFound_NotFound --- PASS: TestResponseErrorIsNotFound_NotFound (0.00s) === RUN TestString --- PASS: TestString (0.00s) === RUN TestInt --- PASS: TestInt (0.00s) === RUN TestNetworkType --- PASS: TestNetworkType (0.00s) === RUN TestRunstate --- PASS: TestRunstate (0.00s) === RUN TestBool --- PASS: TestBool (0.00s) PASS ok github.com/terraform-providers/terraform-provider-skytap/skytap/utils 0.412s FAIL Re-running failed tests (Re-run 01): === RUN TestAccDataSourceSkytapProject_Basic === PAUSE TestAccDataSourceSkytapProject_Basic === RUN TestAccSkytapNetwork_Basic === PAUSE TestAccSkytapNetwork_Basic === RUN TestAccSkytapProject_Basic === PAUSE TestAccSkytapProject_Basic === RUN TestAccSkytapVMCPU_DiskIntact 2020/04/16 14:43:14 [DEBUG] SKYTAP_TEMPLATE_ID=1473407 2020/04/16 14:43:14 [DEBUG] SKYTAP_VM_ID=37865463 2020/04/16 14:43:14 [DEBUG] SKYTAP_TEMPLATE_NEW_ENV_ID=1473407 --- FAIL: TestAccSkytapVMCPU_DiskIntact (878.61s) === RUN TestAccSkytapVM_Concurrent --- FAIL: TestAccSkytapVM_Concurrent (719.53s) === RUN TestAccSkytapVM_UserData --- PASS: TestAccSkytapVM_UserData (266.52s) === RUN TestAccSkytapVM_Labels --- PASS: TestAccSkytapVM_Labels (320.58s) === CONT TestAccDataSourceSkytapProject_Basic === CONT TestAccSkytapProject_Basic === CONT TestAccSkytapNetwork_Basic --- PASS: TestAccSkytapProject_Basic (3.74s) --- PASS: TestAccDataSourceSkytapProject_Basic (6.30s) --- PASS: TestAccSkytapNetwork_Basic (156.31s) FAIL FAIL github.com/terraform-providers/terraform-provider-skytap/skytap 2342.360s FAIL Re-running failed tests (Re-run 02): === RUN TestAccSkytapVMCPU_DiskIntact 2020/04/16 15:25:55 [DEBUG] SKYTAP_TEMPLATE_ID=1473407 2020/04/16 15:25:55 [DEBUG] SKYTAP_VM_ID=37865463 2020/04/16 15:25:55 [DEBUG] SKYTAP_TEMPLATE_NEW_ENV_ID=1473407 --- PASS: TestAccSkytapVMCPU_DiskIntact (462.59s) === RUN TestAccSkytapVM_Concurrent --- FAIL: TestAccSkytapVM_Concurrent (858.48s) FAIL FAIL github.com/terraform-providers/terraform-provider-skytap/skytap 1321.707s FAIL Re-running failed tests (Re-run 03): === RUN TestAccSkytapVM_Concurrent 2020/04/16 16:07:15 [DEBUG] SKYTAP_TEMPLATE_ID=1473407 2020/04/16 16:07:15 [DEBUG] SKYTAP_VM_ID=37865463 2020/04/16 16:07:15 [DEBUG] SKYTAP_TEMPLATE_NEW_ENV_ID=1473407 --- PASS: TestAccSkytapVM_Concurrent (750.48s) PASS ok github.com/terraform-providers/terraform-provider-skytap/skytap 751.029s testing: warning: no tests to run PASS ok github.com/terraform-providers/terraform-provider-skytap/skytap/utils (cached) [no tests to run]
Updating the skytap-sdk-go to fix
I've also updated the acceptance tests to fix a missing template and to make it less flaky
Acceptance Test Results
Acceptance Test runs ? github.com/terraform-providers/terraform-provider-skytap [no test files] === RUN TestUserAgent 2020/04/16 10:46:35 [DEBUG] user agent version (version.go): 0.12.1 2020/04/16 10:46:35 [DEBUG] user agent version (version.go): 0.12.1 --- PASS: TestUserAgent (0.00s) === RUN TestAccDataSourceSkytapProject_Basic === PAUSE TestAccDataSourceSkytapProject_Basic === RUN TestAccDataSourceSkytapTemplate_Basic === PAUSE TestAccDataSourceSkytapTemplate_Basic === RUN TestAccDataSourceSkytapTemplate_RegexMostRecent === PAUSE TestAccDataSourceSkytapTemplate_RegexMostRecent === RUN TestProvider --- PASS: TestProvider (0.00s) === RUN TestProvider_impl --- PASS: TestProvider_impl (0.00s) === RUN TestAccSkytapLabelCategory_Basic --- PASS: TestAccSkytapLabelCategory_Basic (4.43s) === RUN TestAccSkytapLabelCategory_Update --- PASS: TestAccSkytapLabelCategory_Update (4.91s) === RUN TestAccSkytapLabelCategory_MultiValueBasic --- PASS: TestAccSkytapLabelCategory_MultiValueBasic (7.05s) === RUN TestAccSkytapLabelCategory_Duplicated --- PASS: TestAccSkytapLabelCategory_Duplicated (3.39s) === RUN TestAccSkytapEnvironment_Basic --- PASS: TestAccSkytapEnvironment_Basic (106.61s) === RUN TestAccSkytapEnvironment_UpdateTemplate --- PASS: TestAccSkytapEnvironment_UpdateTemplate (236.82s) === RUN TestAccSkytapEnvironment_UpdateTags --- PASS: TestAccSkytapEnvironment_UpdateTags (108.50s) === RUN TestAccSkytapEnvironment_UserData --- PASS: TestAccSkytapEnvironment_UserData (94.39s) === RUN TestAccSkytapEnvironment_UserDataUpdate --- PASS: TestAccSkytapEnvironment_UserDataUpdate (134.47s) === RUN TestAccSkytapEnvironment_Labels --- PASS: TestAccSkytapEnvironment_Labels (147.95s) === RUN TestAccSkytapEnvironment_LabelsUpdate --- PASS: TestAccSkytapEnvironment_LabelsUpdate (142.36s) === RUN TestAccSkytapLabelICNR_Basic --- PASS: TestAccSkytapLabelICNR_Basic (156.50s) === RUN TestAccSkytapNetwork_Basic === PAUSE TestAccSkytapNetwork_Basic === RUN TestAccSkytapNetwork_Update === PAUSE TestAccSkytapNetwork_Update === RUN TestAccSkytapProject_Basic === PAUSE TestAccSkytapProject_Basic === RUN TestAccSkytapVM_Basic --- PASS: TestAccSkytapVM_Basic (290.32s) === RUN TestAccSkytapVM_Timeout --- PASS: TestAccSkytapVM_Timeout (286.86s) === RUN TestAccSkytapVM_Update --- PASS: TestAccSkytapVM_Update (425.72s) === RUN TestAccSkytapVM_Interface --- PASS: TestAccSkytapVM_Interface (805.50s) === RUN TestAccSkytapVM_PublishedService --- PASS: TestAccSkytapVM_PublishedService (973.21s) === RUN TestAccSkytapVM_PublishedServiceBadNic --- PASS: TestAccSkytapVM_PublishedServiceBadNic (194.39s) === RUN TestAccExternalPorts --- PASS: TestAccExternalPorts (416.89s) === RUN TestAccSkytapVM_Typical --- PASS: TestAccSkytapVM_Typical (607.27s) === RUN TestAccSkytapVMCPURam_Create --- PASS: TestAccSkytapVMCPURam_Create (775.32s) === RUN TestAccSkytapVMCPU_DiskIntact --- FAIL: TestAccSkytapVMCPU_DiskIntact (892.29s) === RUN TestAccSkytapVMCPURAM_UpdateNPECheck --- PASS: TestAccSkytapVMCPURAM_UpdateNPECheck (450.22s) === RUN TestAccSkytapVMCPURAM_Invalid --- PASS: TestAccSkytapVMCPURAM_Invalid (0.01s) === RUN TestAccSkytapVMCPU_OutOfRange --- PASS: TestAccSkytapVMCPU_OutOfRange (153.18s) === RUN TestAccSkytapVMCPU_OutOfRangeAfterUpdate --- PASS: TestAccSkytapVMCPU_OutOfRangeAfterUpdate (271.20s) === RUN TestAccSkytapVMDisks_Create --- PASS: TestAccSkytapVMDisks_Create (515.54s) === RUN TestAccSkytapVMDisks_UpdateNPECheck --- PASS: TestAccSkytapVMDisks_UpdateNPECheck (421.14s) === RUN TestAccSkytapVMDisks_Resize --- PASS: TestAccSkytapVMDisks_Resize (477.53s) === RUN TestAccSkytapVMDisk_Invalid --- PASS: TestAccSkytapVMDisk_Invalid (0.01s) === RUN TestAccSkytapVMDisk_OS --- PASS: TestAccSkytapVMDisk_OS (459.54s) === RUN TestAccSkytapVMDisk_OSChangeAfter --- PASS: TestAccSkytapVMDisk_OSChangeAfter (447.88s) === RUN TestAccSkytapVM_Concurrent --- FAIL: TestAccSkytapVM_Concurrent (704.14s) === RUN TestAccSkytapVM_UserData --- FAIL: TestAccSkytapVM_UserData (413.16s) === RUN TestAccSkytapVM_Labels --- FAIL: TestAccSkytapVM_Labels (19.31s) === RUN TestFlattenInterfaces --- PASS: TestFlattenInterfaces (0.00s) === RUN TestFlattenPublishedServices --- PASS: TestFlattenPublishedServices (0.00s) === RUN TestFlattenDisks --- PASS: TestFlattenDisks (0.00s) === RUN TestValidateNICType --- PASS: TestValidateNICType (0.00s) === RUN TestValidateRoleType --- PASS: TestValidateRoleType (0.00s) === RUN TestValidateNoSubString --- PASS: TestValidateNoSubString (0.00s) === RUN TestValidateNoStartWith --- PASS: TestValidateNoStartWith (0.00s) === CONT TestAccDataSourceSkytapProject_Basic === CONT TestAccSkytapNetwork_Update --- FAIL: TestAccDataSourceSkytapProject_Basic (88.27s) === CONT TestAccSkytapProject_Basic --- FAIL: TestAccSkytapProject_Basic (15.32s) === CONT TestAccDataSourceSkytapTemplate_RegexMostRecent --- PASS: TestAccDataSourceSkytapTemplate_RegexMostRecent (149.43s) === CONT TestAccSkytapNetwork_Basic --- PASS: TestAccSkytapNetwork_Update (427.14s) === CONT TestAccDataSourceSkytapTemplate_Basic --- PASS: TestAccDataSourceSkytapTemplate_Basic (10.56s) --- FAIL: TestAccSkytapNetwork_Basic (259.14s) FAIL FAIL github.com/terraform-providers/terraform-provider-skytap/skytap 11660.513s === RUN TestResponseErrorIsNotFound_BadRequest --- PASS: TestResponseErrorIsNotFound_BadRequest (0.00s) === RUN TestResponseErrorIsNotFound_NotFound --- PASS: TestResponseErrorIsNotFound_NotFound (0.00s) === RUN TestString --- PASS: TestString (0.00s) === RUN TestInt --- PASS: TestInt (0.00s) === RUN TestNetworkType --- PASS: TestNetworkType (0.00s) === RUN TestRunstate --- PASS: TestRunstate (0.00s) === RUN TestBool --- PASS: TestBool (0.00s) PASS ok github.com/terraform-providers/terraform-provider-skytap/skytap/utils 0.412s FAIL Re-running failed tests (Re-run 01): === RUN TestAccDataSourceSkytapProject_Basic === PAUSE TestAccDataSourceSkytapProject_Basic === RUN TestAccSkytapNetwork_Basic === PAUSE TestAccSkytapNetwork_Basic === RUN TestAccSkytapProject_Basic === PAUSE TestAccSkytapProject_Basic === RUN TestAccSkytapVMCPU_DiskIntact 2020/04/16 14:43:14 [DEBUG] SKYTAP_TEMPLATE_ID=1473407 2020/04/16 14:43:14 [DEBUG] SKYTAP_VM_ID=37865463 2020/04/16 14:43:14 [DEBUG] SKYTAP_TEMPLATE_NEW_ENV_ID=1473407 --- FAIL: TestAccSkytapVMCPU_DiskIntact (878.61s) === RUN TestAccSkytapVM_Concurrent --- FAIL: TestAccSkytapVM_Concurrent (719.53s) === RUN TestAccSkytapVM_UserData --- PASS: TestAccSkytapVM_UserData (266.52s) === RUN TestAccSkytapVM_Labels --- PASS: TestAccSkytapVM_Labels (320.58s) === CONT TestAccDataSourceSkytapProject_Basic === CONT TestAccSkytapProject_Basic === CONT TestAccSkytapNetwork_Basic --- PASS: TestAccSkytapProject_Basic (3.74s) --- PASS: TestAccDataSourceSkytapProject_Basic (6.30s) --- PASS: TestAccSkytapNetwork_Basic (156.31s) FAIL FAIL github.com/terraform-providers/terraform-provider-skytap/skytap 2342.360s FAIL Re-running failed tests (Re-run 02): === RUN TestAccSkytapVMCPU_DiskIntact 2020/04/16 15:25:55 [DEBUG] SKYTAP_TEMPLATE_ID=1473407 2020/04/16 15:25:55 [DEBUG] SKYTAP_VM_ID=37865463 2020/04/16 15:25:55 [DEBUG] SKYTAP_TEMPLATE_NEW_ENV_ID=1473407 --- PASS: TestAccSkytapVMCPU_DiskIntact (462.59s) === RUN TestAccSkytapVM_Concurrent --- FAIL: TestAccSkytapVM_Concurrent (858.48s) FAIL FAIL github.com/terraform-providers/terraform-provider-skytap/skytap 1321.707s FAIL Re-running failed tests (Re-run 03): === RUN TestAccSkytapVM_Concurrent 2020/04/16 16:07:15 [DEBUG] SKYTAP_TEMPLATE_ID=1473407 2020/04/16 16:07:15 [DEBUG] SKYTAP_VM_ID=37865463 2020/04/16 16:07:15 [DEBUG] SKYTAP_TEMPLATE_NEW_ENV_ID=1473407 --- PASS: TestAccSkytapVM_Concurrent (750.48s) PASS ok github.com/terraform-providers/terraform-provider-skytap/skytap 751.029s testing: warning: no tests to run PASS ok github.com/terraform-providers/terraform-provider-skytap/skytap/utils (cached) [no tests to run]