skytap / terraform-provider-skytap

Terraform Skytap provider
https://www.terraform.io/docs/providers/skytap/
Mozilla Public License 2.0
4 stars 11 forks source link

Make routable and outbound_traffic truly optional #78

Closed snidell closed 2 years ago

snidell commented 2 years ago

@loketan @loketan-zz According to the Terraform docs routable and outbound_traffic are optional parameters.

However, if they are not set by the user they will be set to false. This causes conflicts and provision errors to certain templates that have VPNs attached or have internet disabled feature set to true.

This change seeks to align behavior associated with the REST API of creating an environment. Only required parameters are passed to the create action. Optional parameters are only passed if they are set by the user

Testing: With this change, I have tested against 238 templates that are currently active in our system. Out of 238 tests 238 environments were successfully provisioned and destroyed. Below are the test results of these templates