search

skytap / terraform-provider-skytap

Terraform Skytap provider
https://www.terraform.io/docs/providers/skytap/
Mozilla Public License 2.0
4 stars 11 forks source link

Fixes timeout issue when disabling the internet via outbound_traffic attribute #81

Closed matpimenta closed 1 year ago

matpimenta commented 1 year ago

This PR introduces disable_internet attribute to replace the outbound_traffic (which is now deprecated to align with Skytap V1 API) It also includes some other fixes to avoid displaying plan differences when re-applying Terraform a second time after a skytap_environment was created.

This change still doesn't include stopping/suspending an environment to apply a disable_internet/routable attribute change.

matpimenta commented 1 year ago
Acceptance Test Results ``` --- PASS: TestUserAgent (0.00s) --- PASS: TestProvider (0.00s) --- PASS: TestAccSkytapLabelCategory_Basic (6.32s) --- PASS: TestAccSkytapLabelCategory_Update (8.17s) --- PASS: TestAccSkytapLabelCategory_MultiValueBasic (6.08s) --- PASS: TestAccSkytapLabelCategory_Duplicated (4.31s) --- PASS: TestAccSkytapEnvironment_Basic (127.29s) --- PASS: TestAccSkytapEnvironment_Update (297.32s) --- PASS: TestAccSkytapEnvironment_UpdateTemplate (238.55s) --- PASS: TestAccSkytapEnvironment_UpdateTags (159.91s) --- PASS: TestAccSkytapEnvironment_UserData (158.75s) --- PASS: TestAccSkytapEnvironment_UserDataUpdate (151.37s) --- PASS: TestAccSkytapEnvironment_Labels (153.76s) --- PASS: TestAccSkytapEnvironment_LabelsUpdate (155.65s) --- PASS: TestAccSkytapEnvironment_DisableInternetConflict (0.78s) --- PASS: TestAccSkytapLabelICNR_Basic (188.78s) --- PASS: TestAccSkytapVM_Basic (255.61s) --- PASS: TestAccSkytapVM_Timeout (252.67s) --- PASS: TestAccSkytapVM_Update (421.75s) --- PASS: TestAccSkytapVM_Interface (742.72s) --- PASS: TestAccSkytapVM_PublishedService (949.79s) --- PASS: TestAccSkytapVM_PublishedServiceBadNic (203.77s) --- PASS: TestAccExternalPorts (371.65s) --- PASS: TestAccSkytapVM_Typical (610.34s) --- PASS: TestAccSkytapVMCPURam_Create (797.38s) --- PASS: TestAccSkytapVMCPU_DiskIntact (430.80s) --- PASS: TestAccSkytapVMCPURAM_UpdateNPECheck (408.54s) --- PASS: TestAccSkytapVMCPURAM_Invalid (0.82s) --- PASS: TestAccSkytapVMCPU_OutOfRange (155.58s) --- PASS: TestAccSkytapVMCPU_OutOfRangeAfterUpdate (225.00s) --- PASS: TestAccSkytapVMDisks_Create (452.79s) --- PASS: TestAccSkytapVMDisks_UpdateNPECheck (417.98s) --- PASS: TestAccSkytapVMDisks_Resize (441.10s) --- PASS: TestAccSkytapVMDisk_Invalid (1.05s) --- PASS: TestAccSkytapVMDisk_OS (432.83s) --- PASS: TestAccSkytapVMDisk_OSChangeAfter (451.69s) --- PASS: TestAccSkytapVM_Concurrent (677.88s) --- PASS: TestAccSkytapVM_UserData (265.31s) --- PASS: TestAccSkytapVM_Labels (272.76s) --- PASS: TestFlattenInterfaces (0.00s) --- PASS: TestFlattenPublishedServices (0.00s) --- PASS: TestFlattenDisks (0.00s) --- PASS: TestValidateNICType (0.00s) --- PASS: TestValidateRoleType (0.00s) --- PASS: TestValidateNoSubString (0.00s) --- PASS: TestValidateNoStartWith (0.00s) --- PASS: TestAccDataSourceSkytapTemplate_Basic (6.36s) --- PASS: TestAccSkytapProject_Basic (6.93s) --- PASS: TestAccDataSourceSkytapTemplate_RegexMostRecent (6.98s) --- PASS: TestAccSkytapProject_AddEnvironment (119.54s) --- PASS: TestAccDataSourceSkytapProject_Basic (130.77s) --- PASS: TestAccSkytapNetwork_Basic (164.96s) --- PASS: TestResponseErrorIsNotFound_BadRequest (0.00s) --- PASS: TestResponseErrorIsNotFound_NotFound (0.00s) --- PASS: TestString (0.00s) --- PASS: TestInt (0.00s) --- PASS: TestNetworkType (0.00s) --- PASS: TestRunstate (0.00s) --- PASS: TestBool (0.00s) --- PASS: TestAccSkytapNetwork_Update (183.34s) ```