search

skytap / terraform-provider-skytap

Terraform Skytap provider
https://www.terraform.io/docs/providers/skytap/
Mozilla Public License 2.0
4 stars 11 forks source link

Preventing VM recreation when `network_interface` is changed #83

Closed matpimenta closed 1 year ago

matpimenta commented 1 year ago

This PR removes the ForceNew from the network_interface to avoid recreating the VM on changes.

matpimenta commented 1 year ago
Acceptance Test Results ``` --- PASS: TestUserAgent (0.00s) --- PASS: TestProvider (0.00s) --- PASS: TestFlattenInterfaces (0.00s) --- PASS: TestFlattenPublishedServices (0.00s) --- PASS: TestFlattenDisks (0.00s) --- PASS: TestValidateNICType (0.00s) --- PASS: TestValidateRoleType (0.00s) --- PASS: TestValidateNoSubString (0.00s) --- PASS: TestValidateNoStartWith (0.00s) --- PASS: TestAccSkytapLabelCategory_Duplicated (14.81s) --- PASS: TestAccSkytapLabelCategory_MultiValueBasic (19.91s) --- PASS: TestAccSkytapLabelCategory_Basic (20.22s) --- PASS: TestAccDataSourceSkytapProject_Basic (135.18s) --- PASS: TestAccSkytapEnvironment_UserData (138.95s) --- PASS: TestAccSkytapVMCPU_OutOfRange (159.44s) --- PASS: TestAccSkytapVM_Timeout (285.43s) --- PASS: TestAccSkytapNetwork_Basic (162.26s) --- PASS: TestAccSkytapProject_Basic (20.99s) --- PASS: TestAccSkytapProject_AddEnvironment (149.52s) --- PASS: TestAccSkytapVM_UserData (292.69s) --- PASS: TestAccSkytapVMCPURAM_Invalid (3.68s) --- PASS: TestAccSkytapLabelCategory_Update (23.58s) --- PASS: TestAccSkytapVM_Labels (318.87s) --- PASS: TestAccSkytapVM_Basic (248.47s) --- PASS: TestAccSkytapVMDisk_OSChangeAfter (457.35s) --- PASS: TestAccSkytapNetwork_Update (189.54s) --- PASS: TestAccSkytapVM_Concurrent (645.79s) --- PASS: TestAccSkytapVM_PublishedServiceBadNic (210.88s) --- PASS: TestAccSkytapVMCPURAM_UpdateNPECheck (466.02s) --- PASS: TestAccSkytapVMCPU_DiskIntact (455.34s) --- PASS: TestAccExternalPorts (399.48s) --- PASS: TestAccSkytapVMDisk_Invalid (3.54s) --- PASS: TestAccSkytapVM_Typical (596.59s) --- PASS: TestAccSkytapEnvironment_UpdateTemplate (227.09s) --- PASS: TestAccSkytapEnvironment_UpdateTags (166.34s) --- PASS: TestAccSkytapEnvironment_LabelsUpdate (193.01s) --- PASS: TestAccSkytapEnvironment_Update (264.52s) --- PASS: TestAccSkytapEnvironment_DisableInternetConflict (2.93s) --- PASS: TestAccSkytapVMCPURam_Create (842.40s) --- PASS: TestAccDataSourceSkytapTemplate_RegexMostRecent (16.41s) --- PASS: TestAccSkytapVMDisks_UpdateNPECheck (421.08s) --- PASS: TestAccDataSourceSkytapTemplate_Basic (15.91s) --- PASS: TestAccSkytapEnvironment_Labels (144.07s) --- PASS: TestAccSkytapEnvironment_Basic (136.45s) --- PASS: TestAccSkytapVM_Update (420.15s) --- PASS: TestAccSkytapVMDisks_Resize (487.34s) --- PASS: TestAccSkytapVM_PublishedService (1076.58s) --- PASS: TestAccSkytapEnvironment_UserDataUpdate (179.00s) --- PASS: TestAccSkytapVMCPU_OutOfRangeAfterUpdate (196.89s) --- PASS: TestAccSkytapVM_Interface (855.73s) --- PASS: TestAccSkytapVMDisks_Create (442.01s) --- PASS: TestResponseErrorIsNotFound_BadRequest (0.00s) --- PASS: TestResponseErrorIsNotFound_NotFound (0.00s) --- PASS: TestString (0.00s) --- PASS: TestInt (0.00s) --- PASS: TestNetworkType (0.00s) --- PASS: TestRunstate (0.00s) --- PASS: TestBool (0.00s) --- PASS: TestAccSkytapVMDisk_OS (482.53s) --- PASS: TestAccSkytapVMDisk_OSChangeAfter (522.88s) --- PASS: TestAccSkytapLabelICNR_Basic (188.28s) ```