skyvory / vn-canvas

Automatically exported from code.google.com/p/vn-canvas
0 stars 1 forks source link

"TypeError: Config.activeTheme is undefined" on vntemplate.html, also vntemplate invokes vncanvas-0.3 and not vncanvas-0.4 #13

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
0.5. Unpack vncanvas-0.4.1.zip
1. Open vntemplate.html locally in browser

What is the expected output? What do you see instead?
Assumed it would fallback to default theme, docs suggest config script is 
optional. Throws error and will not continue running script.

What version of the product are you using? On what operating system?
Linux Mint, Firefox 20, vncanvas-0.4.1.zip

Info:

Firefox throws "TypeError: Config.activeTheme is undefined" on page load.

Tried with vncanvas-0.3.js (straight from the .zip, unmolested) and also tried 
with vncanvas-0.4.js and got same result.

Added "vnconfig.js" to the vntoc.js, received "SyntaxError: missing } after 
property list" in addition to the activeTheme error.

Added comma after "actorYPosition:      1.0" (line 76) in vnconfig.js.

That seems to quiet the activeTheme error in firefox.

Takeaway: some kind of config.js is required, not optional. Missing comma in 
vnconfig.js, line 76

Original issue reported on code.google.com by compulsi...@gmail.com on 6 May 2013 at 5:28

GoogleCodeExporter commented 9 years ago
Also vntemplate.html references a style.css that does not exist in the 
directory, I just copied demo-style.css from the demo folder into the template 
folder and renamed it style.css.

Original comment by compulsi...@gmail.com on 6 May 2013 at 5:34

GoogleCodeExporter commented 9 years ago
Sorry for the confusion. vntemplate was not meant to be run like that. It was 
meant only as sample template for those who wanted some html snippets/patterns 
to jumpstart development. If you noticed, it wasn't even in the correct 
directory (but you can always move files around).

As for the config being optional, must have missed a check somewhere. At init 
(line 5231) in 0.4.1, Helper.configUpdate("activeTheme") is being called. Maybe 
I'll add a check at configUpdate to first check if Config is not empty.

Yup, missing comma in vnconfig.js. I was using demo-config.js mostly.

Original comment by oclabbao on 7 May 2013 at 12:35

GoogleCodeExporter commented 9 years ago
I'd like to get vntemplate into a "nearly ready to run" state, such that a new 
user could just start typing their script into chapter1.js and then readily see 
their results in the browser. Preferably with a reasonable stylesheet and 
mostly sane config.

I know it's unfair at this stage to compare vn-canvas to ren'py, but starting a 
new project in ren'py is a matter of opening the IDE, clicking new project, and 
then you can start writing your script... vn-canvas can really reduce the time 
between initial download and "hello world" if the template were ready to rock 
out of the box!

I'm willing to contribute that boilerplate when I get it working. I plan to 
rapidly and regularly produce vn content so when I find a way to get vn-canvas 
on its feet quickly, I'll happily give it to the project.

Original comment by compulsi...@gmail.com on 7 May 2013 at 2:01

GoogleCodeExporter commented 9 years ago
I got your point. And I'll gladly accept your contribution. I need all the help 
I can get. :)  Thanks!

As for ren'py, it's already way up there and vn-canvas is still way down here. 
No contest. :) 

Original comment by oclabbao on 7 May 2013 at 2:41

GoogleCodeExporter commented 9 years ago
vn-canvas will overtake ren'py in time, at least on mobile.

Mozilla is poised to unleash their sub-$50 firefox smart phone to several 
massive markets hungry for the devices - and hungry for content to run on them. 
FF OS apps are all HTML5 and entirely browser-bred. vn-canvas is in a MUCH 
stronger position to take advantage of that than ren'py, whose mobile and 
browser export options are less than ideal.

vn-canvas will not be "way down here" for long.

Original comment by compulsi...@gmail.com on 7 May 2013 at 4:21

GoogleCodeExporter commented 9 years ago
Bold prediction. :)
You do realize this is only a hobby, right?

Original comment by oclabbao on 7 May 2013 at 4:30