skywardmc / adrenaline

Leading, lightweight, and unbiased performance modpack with no QoL features
https://modrinth.com/project/Adrenaline/
MIT License
58 stars 8 forks source link

Some mods aren't here #25

Closed rottakore closed 1 year ago

rottakore commented 1 year ago

Why not include:

I just want to know why because I believe you guys already did a research and it's not really easy to find the "why not to use" answers in the internet about these mods.

I know that:

What about taking a look in this mod Ruthenium, can be better than Dynamic FPS.

MemoryLeakFix got an update! Did you guys see? Maybe it works now and can be re-added?

MenacingPerson commented 1 year ago

LazyDFU and Starlight got obsoleted by 1.19.4 and 1.20.1 respectively. Krypton is useless on clients. C2ME used to be here but was removed due to instability. VMP is useful only on servers. Exordium leads to lower FPS in 1.20.1 in a lot of cases.

A lot of mods you listed are incompatible with Vanilla - those aren't used

Also some mods you listed here are only on curseforge (namely, all the ones by someaddon), which is a problem

Nvidium is not present because it's not stable and only works on nvidia.

There's also some utility mods like logs begone that don't belong.

Also, please split your messages into paragraphs next time. Thanks

Also, try using the search feature on github issues and clicking on the Closed button. You'll see a lot of mods that you mention here, as well as reasons for why they weren't included.

rottakore commented 1 year ago

Edited the original post to be more pleasing to read.

Thanks for your answer!

Super interesting that LazyDFU and Starlight is not necessary anymore, if you know more details about every mod I said, I would appreciate to hear.

Nvidium only works on NVIDIA GPUs but it disables itself if detects non NVIDIA GPUs, so the modpack would still work for everyone. I'm using it, tested it and not a single bug came to my eye, but only a big performance boost.

Good to know that this modpack doesn't want to add performance mods that aren't on modrinth, now I understand that it's not really a 100% complete performance modpack, but just a modrinth performance modpack.

Logs Begone can make a slight good impact on performance if you use this modpack as base to add more mods.

Now I saw the closed issues, there really is a subject for everything there, but the majority of them are outdated.

intergrav commented 1 year ago

I'll give a reason why every single mod that you listed isn't shipped with Adrenaline :) For the mods that I said are "too niche" for Adrenaline, what I mean is that it does insignificant things and is not worth including an entire separate mod for. More mods is not always better - it causes us to take more time to update to newer versions, possibly cause incompatibility with content mods, and in most cases wont be beneficial for the user. Adrenaline is meant to optimize the game as much as possible while staying small.

Good to know that this modpack doesn't want to add performance mods that aren't on modrinth, now I understand that it's not really a 100% complete performance modpack, but just a modrinth performance modpack.

This is not the case at all - it would be illegal for me to add someaddon's mods to Adrenaline for the reasoning I stated below. I am willing to add performance mods from CurseForge if it doesn't break licensing and the author is okay with it. Every other mod that you listed here is available on Modrinth and CurseForge, it's simply someaddon's mods that aren't.

Gaming32 commented 1 year ago

Additionally, FastQuit is in Additive.