skywardmc / adrenaline

Leading, lightweight, and unbiased performance modpack with no QoL features
https://modrinth.com/project/Adrenaline/
MIT License
59 stars 9 forks source link

Add Nvidium #35

Closed intergrav closed 5 months ago

intergrav commented 7 months ago

Sometime in the future I plan on including Nvidium in Adrenaline by default as it disables itself on unsupported GPUs and is in a relatively stable state by now. Will require a lot of testing though. This issue is here to track progress.

@MCRcortex GitHub Repository: https://github.com/MCRcortex/nvidium Issue Tracker: https://github.com/MCRcortex/nvidium/issues Modrinth Page: https://modrinth.com/mod/nvidium

intergrav commented 7 months ago

The main issue right now is that I personally don't have a compatible Nvidia GPU to test this with. I will need to rely on community support and feedback.

omo50 commented 7 months ago

Personally, ive seen performance increases up to ~2.5x with Nvidium

i think that its a very good mod, and i feel it may worth it to add? It is much more stable than it was upon first release

omo50 commented 7 months ago

Performance probably varies decently between graphics cards tho. I could do some benchmarking if you'd like (you mentioned you do not have a compatible gpu)

intergrav commented 7 months ago

I could do some benchmarking if you'd like (you mentioned you do not have a compatible gpu)

Benchmarks aren't necessary but could be helpful. The main thing I'm worried about is (very rare) issues people may experience during gameplay, such as crashes and whatnot.

omo50 commented 7 months ago

I see. I've personally never had a crash related to Nvidium (in modpacks with >300 mods aswell) I've played with probably around 100 hours with the mod and to my experience its stable enough, but could probably vary for other people

seriousfreezing commented 7 months ago

My experience with him is highly positive. Even though I keep fiddling with all its settings like crazy, hoping that at some point it will blow up my computer, it has never broken or even crashed in any of my uses. It's just perfect.

WaffleIBOT commented 7 months ago

It is quite good as a chunked distance increase mod, it performs better than Distants Horizons, it would be nice if it was included but disabled by default.

omo50 commented 7 months ago

Benchmarks aren't necessary but could be helpful.

Decided to quickly benchmark the most recent version of Adrenaline with and without Nvidium I have a 3060 for my GPU. Tested on the same world at 32 render distance and 32 simulation distance. Elsewise all settings were modpack default

image

I saw a performance increase of ~35% which is a major increase. Hope it helps 👍

intergrav commented 7 months ago

Thanks! This is a nice thing to have. I've heard from some of my friends that they had a pretty noticeable improvement as well

intergrav commented 7 months ago

cortex said that personally it should be fine for general usage and many people have said it's good so i'll just add this now

omo50 commented 7 months ago

Will this change be put into Additive as well? Curious

intergrav commented 7 months ago

yes, changes from Adrenaline get put into Additive too (when possible)

omo50 commented 7 months ago

👍 hope to have helped in some way with this

intergrav commented 7 months ago

I've temporarily removed Nvidium until https://github.com/MCRcortex/nvidium/pull/173 is merged

intergrav commented 5 months ago

Pull request is merged and version is published, will add to Adrenaline