skywardmc / threadtweak

Improve and tweak Minecraft thread scheduling (again!)
https://modrinth.com/mod/threadtweak
MIT License
21 stars 6 forks source link

Conflict with Iris Shaders 1.6.10 #8

Closed RoonMoonlight closed 8 months ago

RoonMoonlight commented 8 months ago

Hello, after updating Iris Shaders 1.6.10 on my modpack, it seems your ThreadTweak mod is conflicting with Iris, since there is com.github.getchoo.smoothboot.mixin.client.MainMixin (smoothboot.mixins.json) on Mixin Trace. Would be grateful if you could look what happened.

Crash Report: https://mclo.gs/K0lQqVH

Thanks

Phoenix-Starlight commented 8 months ago

No it is not threadtweak, try again with a new instance. In fact, your crash report has no mention of it.

RoonMoonlight commented 8 months ago

No it is not threadtweak, try again with a new instance. In fact, your crash report has no mention of it.

Look at the com.github.getchoo.smoothboot.mixin.client.MainMixin (smoothboot.mixins.json mention again on crash report

UPDATE: This is weird. after removing ThreadTweak now it says

org.embeddedt.modernfix.common.mixin.bugfix.world_leaks.MinecraftMixin (modernfix-common.mixins.json)
        org.embeddedt.modernfix.common.mixin.bugfix.concurrency.MinecraftMixin (modernfix-common.mixins.json)
        org.embeddedt.modernfix.fabric.mixin.feature.measure_time.MinecraftMixin_Fabric (modernfix-fabric.mixins.json)
        org.embeddedt.modernfix.fabric.mixin.core.MCMixin_Fabric (modernfix-fabric.mixins.json)

Will close this, and will go report that crash to author of ModernFix (for now)

uku3lig commented 8 months ago

while i am sure it's not a threadtweak issue, i can at the very least provide some insight on the problem.

the mod causing the issue here is indium. it's trying to access something that for some unknown (and probably extremely cursed) reason isn't here (intermediary mappings).

the reason why you're seeing threadtweak and modernfix (among other mods) is because they mixin into some essential classes of minecraft, namely Main and MinecraftClient (which, due to being used to literally launch the game, will almost always show up in stack traces).

so, according to what you said about updating iris to 1.6.10, while unlikely it seems possible that it could be the issue.

RoonMoonlight commented 8 months ago

This is weird, Fabulously Optimized works even that mod has Iris updated... I can see some Prism Launcher on error log, I will try using Modrinth App instead (as that launcher worked like a charm before)

uku3lig commented 8 months ago

I can see some Prism Launcher on error log

that's because you're using prism launcher. it is not the cause of the error.

you could also try downgrading your fabric loader to 0.14.22

MenacingPerson commented 8 months ago

Try removing fabric loader and adding it again. @RoonMoonlight

RoonMoonlight commented 8 months ago

while i am sure it's not a threadtweak issue, i can at the very least provide some insight on the problem.

the mod causing the issue here is indium. it's trying to access something that for some unknown (and probably extremely cursed) reason isn't here (intermediary mappings).

the reason why you're seeing threadtweak and modernfix (among other mods) is because they mixin into some essential classes of minecraft, namely Main and MinecraftClient (which, due to being used to literally launch the game, will almost always show up in stack traces).

so, according to what you said about updating iris to 1.6.10, while unlikely it seems possible that it could be the issue.

Okay I will forward this to Indium repo

uku3lig commented 8 months ago

please try what i suggested first, downgrading iris and/or fabric loader. please don't bother other mod devs until you're 100% sure it comes from their mod

RoonMoonlight commented 8 months ago

please try what i suggested first, downgrading iris and/or fabric loader. please don't bother other mod devs until you're 100% sure it comes from their mod

Because I don't even KNOW WHERE TO GET SOLUTIONS. I am modpack dev and I need this to be addressed first to get it released

uku3lig commented 8 months ago

have you tried what i said? and if yes, did it fix your issues?

intergrav commented 8 months ago

Geez no one is actually trying to be helpful...

Friendly reminder not to say this kind of stuff. Doing this will only make the people who are helping you not want to continue helping.