cursor not closed in stardict.py

skywind3000 / ECDICT

Free English to Chinese Dictionary Database

MIT License

5.93k stars 1.04k forks source link

cursor not closed in stardict.py #40

Closed urna closed 5 years ago

urna commented 5 years ago

In "stardict.py", cursors are not closed after using, not sure whether there will be memory leak issue.

But in sqlite3 c source code, the "close" function is not empty pysqlite_cursor_close: (void)pysqlite_statement_reset(self->statement); Py_CLEAR(self->statement);

However, I think it is better to close cursors ASAP, saving memory when running on cheaper cloud VMs.

skywind3000 commented 5 years ago

Right now I have no time working on it. You can send me PR for this.

urna commented 5 years ago

i will study how PR works

urna commented 5 years ago

had sent PR for this