skywind3000 / vim-terminal-help

Small changes make vim/nvim's internal terminal great again !!
MIT License
247 stars 32 forks source link

Using git commit inside vim terminal #20

Open SeraphRoy opened 4 years ago

SeraphRoy commented 4 years ago

I am having trouble using git commit inside a vim terminal with the drop command introduced in this plugin. Inside a vim terminal, if I set EDITOR=vim and VISUAL=vim, when I do git commit it opens a new vim inside the outer vim, which I believe is what drop is trying to solve. If I set them to =drop, it does open a new vim tab of the outer vim, but the git commit process inside exits immediately as if I close the editor immediately even though the tab that opens the .git/COMMIT_EDITMSG is still running. Here's the output:

❯ git commit
hint: Waiting for your editor to close the file... 
Aborting commit due to empty commit message.

Not sure if this is even solvable but it would be nice for drop to be even smarter about this.