Value did change - Githubissues

skywinder / ActionSheetPicker-3.0

Quickly reproduce the dropdown UIPickerView / ActionSheet functionality on iOS.

BSD 3-Clause "New" or "Revised" License

3.4k stars 740 forks source link

Open tbaranes opened 8 years ago

tbaranes commented 8 years ago

I was looking for a delegate or block to have a "valueDidChange" callback, but can't found one. I suppose that didn't be implemented?

tbaranes commented 8 years ago

After looking in the code, I'm not sure what would be the best solution to implement this feature in order to respect the current architecture:

A delegate firing a selectedRowDidChange:(NSInteger)rowSelected selectedValue:(id)selectedValue, it could copy the actionSheetPickerDidCancel:(AbstractActionSheetPicker *)actionSheetPicker origin:(id)origin; implementation
Add a new showPickerWithTitle: with a third block selectedRowDidChange:
Just make selectedIndex KVO compliant
The three above solutions (more flexible)

What do you think?

skywinder commented 8 years ago

@tbaranes Do you mind submitting a pull request with this? I agree with you.

tbaranes commented 8 years ago

Alright, I will work on this next week. Which final implementation do your prefer?

skywinder commented 8 years ago

1-st and 2nd is more common cases. So, let's go with this options! :+1:

tbaranes commented 8 years ago

Well, finally I didn't get the time to do it. If not done later, I will do it! :)

skywinder commented 8 years ago

@tbaranes thank you! no rush :+1:

ghost commented 8 years ago

Hey @skywinder , I need this feature in my app. I need to change 2nd rows value according to 1st row selected Value...

skywinder commented 8 years ago

@SnehaDudhat nothing is impossible! Please have a look how AbstractActionSheetPicker looks like. it also

change 2nd rows value according to 1st row selected Value

You can also create your picker based on AbstractActionSheetPicker or ActionSheetCustomPicker to implement it.