search

skywinder / ActionSheetPicker-3.0

Quickly reproduce the dropdown UIPickerView / ActionSheet functionality on iOS.
http://skywinder.github.io/ActionSheetPicker-3.0
BSD 3-Clause "New" or "Revised" License
3.4k stars 740 forks source link

Cropping occurring with multiple string picker #340

Open nnhubbard opened 7 years ago

nnhubbard commented 7 years ago

We are getting cropping of text in some of the picker rows:

screen shot 2017-04-20 at 12 15 19 pm

Is there a solution for this?

skywinder commented 7 years ago

Hi! is this Custom picker? if so: I would recommend to merge "." and " ' " to previous columns. i.e. add it to the end of each digits. then it will be just 6 colums and width shoud be enoght. What do you think about this solution? btw, it looks nice. I htink we can add this picker to set of pickers, I you don't mind!

On Fri, Apr 21, 2017 at 3:15 AM Nic Hubbard notifications@github.com wrote:

We are getting cropping of text in some of the picker rows:

[image: screen shot 2017-04-20 at 12 15 19 pm] https://cloud.githubusercontent.com/assets/30858/25248419/0c12d3dc-25c3-11e7-83af-e21c07db52ba.png

Is there a solution for this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/skywinder/ActionSheetPicker-3.0/issues/340, or mute the thread https://github.com/notifications/unsubscribe-auth/ADM3Om6C-HW48x2prfex6YfUzWaH3DYiks5rx67ggaJpZM4NDdYh .

nnhubbard commented 7 years ago

This is using ActionSheetMultipleStringPicker. I removed the . and ' completely and there is still cropping:

screen shot 2017-04-20 at 12 27 31 pm

Cropping is worse on an iPhone 5:

screen shot 2017-04-20 at 12 35 34 pm

Is there a way for me to make the font size smaller?

This didn't used to be an issue in the old version of ActionSheetPicker but when I upgraded to 3.0 it started happening.

skywinder commented 7 years ago

it was totally rerecreated for new verions of iOS. The only easiest way, that I see to fix this - is merge couple of columns to one (from 0 to 99). Or you can fully customize it via CustomAcitonSheetPicker.

On Fri, Apr 21, 2017 at 3:36 AM Nic Hubbard notifications@github.com wrote:

This is using ActionSheetMultipleStringPicker. I removed the . and ' completely and there is still cropping:

[image: screen shot 2017-04-20 at 12 27 31 pm] https://cloud.githubusercontent.com/assets/30858/25248946/e7e9a786-25c4-11e7-8107-9d96e53ad87e.png

Cropping is worse on an iPhone 5:

[image: screen shot 2017-04-20 at 12 35 34 pm] https://cloud.githubusercontent.com/assets/30858/25249196/e7ccef8c-25c5-11e7-93df-d88232fa8330.png

Is there a way for me to make the font size smaller?

This didn't used to be an issue in the old version of ActionSheetPicker but when I upgraded to 3.0 it started happening.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/skywinder/ActionSheetPicker-3.0/issues/340#issuecomment-295873581, or mute the thread https://github.com/notifications/unsubscribe-auth/ADM3OiINDTLWijc0mJdVbvf_--50JdETks5rx7OzgaJpZM4NDdYh .

nnhubbard commented 7 years ago

How would the CustomActionSheetPicker help with this issue?