search

skywinder / ActionSheetPicker-3.0

Quickly reproduce the dropdown UIPickerView / ActionSheet functionality on iOS.
http://skywinder.github.io/ActionSheetPicker-3.0
BSD 3-Clause "New" or "Revised" License
3.4k stars 739 forks source link

Add more Collaborators to ActionSheetPicker-3.0 #348

Open skywinder opened 7 years ago

skywinder commented 7 years ago

I want other people to feel like they own ActionSheetPicker-3.0, too, so it helps in the long run.

What I'm looking for is people who can:

All when you have time and feel like it. It's not meant to be a burden.

Don't ever feel bad for not contributing to open source. —@alloy

Thanks to @searls for the push to do this by this talk.

If you're interested in helping out – when it's convenient for you – comment on this issue and I'll add you as a committer with push access.

Cheers! :smile: :computer: :earth_africa:

/cc @ainopara @delackner @velga @kashifhisam @TimCinel

xjki commented 7 years ago

Would be interested to help.

skywinder commented 5 years ago

@xjki @moheny if you are interested to help this project - I would be glad to make a work group with you 👍

xjki commented 5 years ago

Let's give it a try.

moheny commented 5 years ago

@skywinder Sure.

skywinder commented 5 years ago

awesome! Thanks for a quick response. I'm here to gelp Let's do it together. 👍 Here are some tasks:

I will try to fix them all, and feel free to participate. Becoming collaborator - is a kind of responsibility. I would be glad to add initiative persons to collaborators after several reviews. 🎉

xjki commented 5 years ago

It would be important for me to understand what is the strategy for maintaining library. For example - how many iOS versions back support is planned? (in my opinion - supporting current and 2 versions back is reasonable target), is rewrite to Swift a goal or is good compatibility enough? (issues asking for Swift support? rewrite?). Better Swift interop can be addressed with better header comments (or with Swift wrapper insetad of full rewrite). Also I think many of the issues are asking to address very specific edge cases (that in my opinion should not be in the scope of the library, like https://github.com/skywinder/ActionSheetPicker-3.0/issues/355).

skywinder commented 4 years ago

Cc @BubiDevs (since you are actively working with this project 👍)

jpmeenaa commented 4 years ago

Would be interested to help.

vincedev commented 4 years ago

@skywinder , @others Also interested to help. I have forked the repository, but I admit I don't know where to start. The repo has 94 active issues, 13 PR waiting, and worse, 46 branches 😳 .. Is it possible to clean this repo before anything else ?

andreabusi commented 4 years ago

Hi @skywinder! I'm interested to help on this project, since I'm currently use the repo in a project.

As @vincedev noted, the repo needs some cleanup because there are some stuff that could be closed or removed.

Can we discuss an initial clean-up plan and an evolution process for this repo?

skywinder commented 4 years ago

@BubiDevs Grazie! I really appreciate your help. 🙏 send me please a message to Telegram (same nickname: skywinder) or email, let's arrange a small call and sync, what and how can we can do this.

p.s. in which app are you using this library?

skywinder commented 4 years ago

@vincedev please, feel free to attend to our init call. let's arrange it together. I will get an intro, and will help to the cleanup repo and show how it works! Same thing, send me a message to telegram/email. And let's arrange a call in zoom.

Thank you guys, you rock!

andreabusi commented 4 years ago

@BubiDevs Grazie! I really appreciate your help. 🙏 send me please a message to Telegram (same nickname: skywinder) or email, let's arrange a small call and sync, what and how can we can do this.

p.s. in which app are you using this library?

Ok many thanks! I will add you on Telegram! 🚀

PS: I'm using this library in Syncrogest app, an app that I develop for a customer.

skywinder commented 4 years ago

Perfect. Just added your app to https://github.com/skywinder/ActionSheetPicker-3.0/wiki/Apps-using-ActionSheetPicker-3.0

skywinder commented 4 years ago

Hello! I updated pod, merged as much as I can. Now looks that it works on iOS 13 and all kind of iPads.

Thank you, everyone, for the support! I also add contributors to the readme that help me a lot. (#451).

skywinder commented 4 years ago

@xjki, @BubiDevs thank you for continuous support and resolving the issues. Much appreciated!

Thanks for constant contributions and helping with answering to the questions. You help me a lot. 🖖So I will add you to collaborators. It will grant you access to repo management.

Congrats, and much appreciated! So welcome to Collaborators family! 🎉

@vincedev it's clean and up now. So feel free to use it. The up-to-date version in develop branch.

skywinder commented 4 years ago

or example - how many iOS versions back support is planned? (in my opinion - supporting current and 2 versions back is reasonable target), is rewrite to Swift a goal or is good compatibility enough? (issues asking for Swift support? rewrite?). Better Swift interop can be addressed with better header comments (or with Swift wrapper insetad of full rewrite). Also I think many of the issues are asking to address very specific edge cases (that in my opinion should not be in the scope of the library, like #355).

Update about your questions:

  1. I think we should stop support ios prior to 8.0 with the next major release. it will allow us to make much cleaner code.
  2. I want to test it on Swift 4.2 #401 (if someone can help to update/migrate it to modern Swift support - it would be cool. Just wondering, what range of swift versions can (and should) support. Thougts?
andreabusi commented 4 years ago

@xjki, @BubiDevs thank you for continuous support and resolving the issues. Much appreciated!

Thanks for constant contributions and helping with answering to the questions. You help me a lot. 🖖So I will add you to collaborators. It will grant you access to repo management.

Congrats, and much appreciated! So welcome to Collaborators family! 🎉

@vincedev it's clean and up now. So feel free to use it. The up-to-date version in develop branch.

Oh many thanks! Will be a pleasure to help on this repo! 🚀

andreabusi commented 4 years ago

@skywinder this is my plan to discuss the evolution process of the repo:

What do you think?

PS: can we create a Slack workspace to discuss this general stuff?

skywinder commented 4 years ago

sounds good. Let's give a try!

a 5 cents from me:

andreabusi commented 4 years ago

sounds good. Let's give a try!

a 5 cents from me:

  • About branch model: As for me - I prefer to do it in git-flow way with main development in develop and make a branch for each feature. We can do any kind of dev process - I'm open.

I'm not so used to git-flow but I can learn :P. For the specific case, I mean to create a branch on which put the work-in-progress PROPOSAL.md file. Could be feature/evolution-proposals the branch name?

  • About communication - I'm also like slack more than other messengers. But in my experience Discord is more popular between open source projects. Proven by many projects. Again - I'm open to any option if it helps to the project!

Ok, we can use Discord, no problem for me.

I will create the Discord project and the dedicated issue soon :)

andreabusi commented 4 years ago

Here is the link for Discord: https://discord.gg/jnYVY2

skywinder commented 4 years ago

Invite doesn’t work feel free to to make a PR with permanent link, btw

On Fri, 13 Dec 2019 at 01:05, Andrea notifications@github.com wrote:

Here is the link for Discord: https://discord.gg/jnYVY2

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/skywinder/ActionSheetPicker-3.0/issues/348?email_source=notifications&email_token=AAZTOOXKFVYKBB7I2OGQQK3QYJVMLA5CNFSM4DMVEYS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGXK27Q#issuecomment-565095806, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZTOOVXOPMZEJEPAR4HTALQYJVMLANCNFSM4DMVEYSQ .

--

Regards, Petr Korolev

andreabusi commented 4 years ago

Invite doesn’t work feel free to to make a PR with permanent link, btw On Fri, 13 Dec 2019 at 01:05, Andrea @.***> wrote: Here is the link for Discord: https://discord.gg/jnYVY2 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#348?email_source=notifications&email_token=AAZTOOXKFVYKBB7I2OGQQK3QYJVMLA5CNFSM4DMVEYS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGXK27Q#issuecomment-565095806>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZTOOVXOPMZEJEPAR4HTALQYJVMLANCNFSM4DMVEYSQ . -- --- Regards, Petr Korolev

My fault, I used a link with an expiration day.

I've made a PR with the right Discord link :)

abdelmagied94 commented 4 years ago

@skywinder I would be glad to help

skywinder commented 4 years ago

@abdelmagied94 thank you, glad to hear. I would be very helpful with the 2 following things:

skywinder commented 4 years ago

Please, have a look on #460

cc @abdelmagied94

StefaniOSApps commented 4 years ago

@BubiDevs Please, have a look on #460

noorulain17 commented 4 years ago

@skywinder I would be glad to help 🎉

skywinder commented 4 years ago

@noorulain17 hooray! Are you using the library now? I would be glad. Can you please review open pull requests so that we can update the library for ios 14.0.

noorulain17 commented 4 years ago

@noorulain17 hooray! Are you using the library now? I would be glad. Can you please review open pull requests so that we can update the library for ios 14.0.

@skywinder yeah I'm using this library in two of my apps that are live on AppStore.

Sure, I'll review the other open PRs, though I've opened the iOS 14.0 one.

RahulTak commented 2 years ago

would be glad to help you

glennposadas commented 2 months ago

We had a crash. I'll also contribute if the ticket and solution do not exist yet. Thanks for this!