search

skywinder / ActionSheetPicker-3.0

Quickly reproduce the dropdown UIPickerView / ActionSheet functionality on iOS.
http://skywinder.github.io/ActionSheetPicker-3.0
BSD 3-Clause "New" or "Revised" License
3.4k stars 740 forks source link

Fixed rotate bug. #379

Closed longjun-9 closed 4 years ago

longjun-9 commented 6 years ago
  1. OrientationMaskSupportsOrientation Macro is not right，fixed it.
  2. It seems that the objective-c demo picker doesn’t support rotation, so, when it is rotated to an unsupported direction，it should be dismissed.
skywinder commented 4 years ago

Hello, @longjun-9 sorry for long waiting. I'm back in the project and want to cleanup it a bit. Yeah, orientation is quite challenging. I really want fix rest of the bugs. Is your fix still actual? it's not very clear from the code, how it should operate in a different situations. Can you add some commets into the code to make it a bit clear?

skywinder commented 4 years ago

ooops. I broke your PR, sorry @longjun-9

(can't understand, which command allows me to add commits to others PR's ¯_(ツ)_/¯

I read about this error here: https://stackoverflow.com/questions/10298291/cannot-push-to-github-keeps-saying-need-merge