Fix run ActionSheetPickerTests on Xcode and Travis CI

skywinder / ActionSheetPicker-3.0

Quickly reproduce the dropdown UIPickerView / ActionSheet functionality on iOS.

http://skywinder.github.io/ActionSheetPicker-3.0

BSD 3-Clause "New" or "Revised" License

3.4k stars 740 forks source link

Fix run ActionSheetPickerTests on Xcode and Travis CI #393

Closed nowsprinting closed 6 years ago

nowsprinting commented 6 years ago

Remove shared scheme ActionSheetPickerTests (need only on build target)
Remove TestTableViewController.m from build target ActionSheetPickerTests's membership
Fix .travis.yml
- Remove commented-out lines
- Fix specified scheme name
- Add osx_image
- Add -destination option on xcodebuild command
Fix tests
- Fix duplicate global field (UIView)origin

saad352 commented 6 years ago

Any idea when this pull request will be merged? The main developers doesn't seem to be active.

nowsprinting commented 6 years ago

@saad352 This repository owner looks active to me. I think that it will be merged someday, so I will wait. (and pray...)

skywinder commented 6 years ago

@nowsprinting yay! thank a lot. I'm very appreciated for that fix! Sorry for a long answer. I'm fully on other project and sometimes miss the PR's here.

nowsprinting commented 6 years ago

@skywinder Thanks!