Fix leaked memory when present Popoverview on iPad

skywinder / ActionSheetPicker-3.0

Quickly reproduce the dropdown UIPickerView / ActionSheet functionality on iOS.

http://skywinder.github.io/ActionSheetPicker-3.0

BSD 3-Clause "New" or "Revised" License

3.4k stars 740 forks source link

Fix leaked memory when present Popoverview on iPad #404

Closed vinhtnk closed 4 years ago

vinhtnk commented 5 years ago

Current when tap outside PopoverViewController, the PopoverViewController with picker closed but doesn't release. It causes leaked memory every time show a picker. Dismiss picker to release when tap outside PopoverViewController.

skywinder commented 4 years ago

Looks very clear. THank you, @vinhtnk I will double check it and will merge it soon! 👍

skywinder commented 4 years ago

@all-contributors please add @vinhtnk for security, code

allcontributors[bot] commented 4 years ago

@skywinder

I've put up a pull request to add @vinhtnk! :tada: