search

skywinder / ActionSheetPicker-3.0

Quickly reproduce the dropdown UIPickerView / ActionSheet functionality on iOS.
http://skywinder.github.io/ActionSheetPicker-3.0
BSD 3-Clause "New" or "Revised" License
3.4k stars 740 forks source link

Feature swift 4.2 migration #409

Closed oklimberg closed 4 years ago

oklimberg commented 5 years ago

I updated the project to the current recommended settings of Xcode 10.1, fixed some warnings and converted the Swift Sample project to Swift 4.2.

If there needs more to be done for Swift 4.2 migration, please lt me know.

skywinder commented 4 years ago

Thanks, @oklimberg . Is it automatic migration by Xcode? Did you add extra feature from your side?

oklimberg commented 4 years ago

Hi, and sorry for the late reply. I did not add any new feature and only applied changes suggested by Xcode.

skywinder commented 4 years ago

Hello, @oklimberg . Thank you for effort. I just updated the project, sadly it gets' a lot of conflicts for now.

I tried to merge your PR, but get a lot of errors, and finally, when I build a project it starts to throw errors. So I have to close this PR in favor of the newer version. But thank you very much for update. my fault, that I didn't update it in timing manner before. I will do my best to support it in future.

skywinder commented 4 years ago

I updated many files in recent update #447. please feel free to check, If I need to update something. I see your changes in code. I'm out of ios dev now. So your suggestions are more than welcome