skywinder / ActionSheetPicker-3.0

Quickly reproduce the dropdown UIPickerView / ActionSheet functionality on iOS.
http://skywinder.github.io/ActionSheetPicker-3.0
BSD 3-Clause "New" or "Revised" License
3.4k stars 740 forks source link

Add iOS 13 support - Handle UIWindow for iOS 13 changes #425

Closed andreabusi closed 4 years ago

andreabusi commented 5 years ago

Handle UIWindow for iOS 13 changes

skywinder commented 4 years ago

Thank you very much, @BubiDevs is it related to #424 ?

andreabusi commented 4 years ago

Thank you very much, @BubiDevs is it related to #424 ?

No, issue #424 is only related to the dark mode support.

This PR is to support new UIWindow and UIScene management introduced with iOS 13 and Xcode 11.

andreabusi commented 4 years ago

@skywinder Fixes done, I dropped the commit with changes related to the podspec file :)

skywinder commented 4 years ago

And the second thing: Travis is failed to build and test your branch. Let's figure out what's wrong there and fix it before merge:

Testing failed:

    Use of undeclared identifier 'UIScene'

    Use of undeclared identifier 'scene'

    Property 'connectedScenes' not found on object of type 'UIApplication *'

    Use of undeclared identifier 'scene'; did you mean 'scanf'?

    Use of undeclared identifier 'UIWindowScene'

    Use of undeclared identifier 'scene'; did you mean 'scanf'?

    Unknown type name 'UIWindowScene'; did you mean 'UIWindowLevel'?

    Expected expression

    Use of undeclared identifier 'UIWindowScene'; did you mean 'windowScene'?

    No visible @interface for 'UIWindow' declares the selector 'initWithWindowScene:'

** TEST FAILED **

https://travis-ci.org/skywinder/ActionSheetPicker-3.0?utm_medium=notification&utm_source=github_status

So You have to update .travis.yml file as well : to pass tests osx_image: xcode11.2

skywinder commented 4 years ago

p.s. I tried to fix it. But can't push travis support to this PR, looks like you have to allow me to do this image https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

andreabusi commented 4 years ago

p.s. I tried to fix it. But can't push travis support to this PR, looks like you have to allow me to do this image https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Permission are already enable, could you check?

andreabusi commented 4 years ago

And the second thing: Travis is failed to build and test your branch. Let's figure out what's wrong there and fix it before merge:

Testing failed:

  Use of undeclared identifier 'UIScene'

  Use of undeclared identifier 'scene'

  Property 'connectedScenes' not found on object of type 'UIApplication *'

  Use of undeclared identifier 'scene'; did you mean 'scanf'?

  Use of undeclared identifier 'UIWindowScene'

  Use of undeclared identifier 'scene'; did you mean 'scanf'?

  Unknown type name 'UIWindowScene'; did you mean 'UIWindowLevel'?

  Expected expression

  Use of undeclared identifier 'UIWindowScene'; did you mean 'windowScene'?

  No visible @interface for 'UIWindow' declares the selector 'initWithWindowScene:'

** TEST FAILED **

https://travis-ci.org/skywinder/ActionSheetPicker-3.0?utm_medium=notification&utm_source=github_status

So You have to update .travis.yml file as well : to pass tests osx_image: xcode11.2

Updated travis.yml file

andreabusi commented 4 years ago

PR rebased on the current develop branch

skywinder commented 4 years ago

She still has issues with Travis. I'm ready to merge with next version as soon as we fix travis issue. @BubiDevs

andreabusi commented 4 years ago

She still has issues with Travis. I'm ready to merge with next version as soon as we fix travis issue. @BubiDevs

Ok issue solved, the Simulator used in the travis file was not valid with the new Xcode image 🤷‍♂️

Also PR rebased on the current develop branch.

skywinder commented 4 years ago

Yay! thank you very much!