Closed andreabusi closed 4 years ago
Thank you very much, @BubiDevs is it related to #424 ?
Thank you very much, @BubiDevs is it related to #424 ?
No, issue #424 is only related to the dark mode support.
This PR is to support new UIWindow and UIScene management introduced with iOS 13 and Xcode 11.
@skywinder Fixes done, I dropped the commit with changes related to the podspec file :)
And the second thing: Travis is failed to build and test your branch. Let's figure out what's wrong there and fix it before merge:
Testing failed:
Use of undeclared identifier 'UIScene'
Use of undeclared identifier 'scene'
Property 'connectedScenes' not found on object of type 'UIApplication *'
Use of undeclared identifier 'scene'; did you mean 'scanf'?
Use of undeclared identifier 'UIWindowScene'
Use of undeclared identifier 'scene'; did you mean 'scanf'?
Unknown type name 'UIWindowScene'; did you mean 'UIWindowLevel'?
Expected expression
Use of undeclared identifier 'UIWindowScene'; did you mean 'windowScene'?
No visible @interface for 'UIWindow' declares the selector 'initWithWindowScene:'
** TEST FAILED **
So You have to update .travis.yml
file as well :
to pass tests
osx_image: xcode11.2
p.s. I tried to fix it. But can't push travis support to this PR, looks like you have to allow me to do this https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork
p.s. I tried to fix it. But can't push travis support to this PR, looks like you have to allow me to do this https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork
Permission are already enable, could you check?
And the second thing: Travis is failed to build and test your branch. Let's figure out what's wrong there and fix it before merge:
Testing failed: Use of undeclared identifier 'UIScene' Use of undeclared identifier 'scene' Property 'connectedScenes' not found on object of type 'UIApplication *' Use of undeclared identifier 'scene'; did you mean 'scanf'? Use of undeclared identifier 'UIWindowScene' Use of undeclared identifier 'scene'; did you mean 'scanf'? Unknown type name 'UIWindowScene'; did you mean 'UIWindowLevel'? Expected expression Use of undeclared identifier 'UIWindowScene'; did you mean 'windowScene'? No visible @interface for 'UIWindow' declares the selector 'initWithWindowScene:' ** TEST FAILED **
So You have to update
.travis.yml
file as well : to pass testsosx_image: xcode11.2
Updated travis.yml
file
PR rebased on the current develop
branch
She still has issues with Travis. I'm ready to merge with next version as soon as we fix travis issue. @BubiDevs
She still has issues with Travis. I'm ready to merge with next version as soon as we fix travis issue. @BubiDevs
Ok issue solved, the Simulator used in the travis file was not valid with the new Xcode image 🤷♂️
Also PR rebased on the current develop branch.
Yay! thank you very much!
Handle UIWindow for iOS 13 changes