search

skywinder / ActionSheetPicker-3.0

Quickly reproduce the dropdown UIPickerView / ActionSheet functionality on iOS.
http://skywinder.github.io/ActionSheetPicker-3.0
BSD 3-Clause "New" or "Revised" License
3.4k stars 740 forks source link

Fix podspec #455

Closed ElfSundae closed 4 years ago

ElfSundae commented 4 years ago

deployment_target is in conflict with platform, and deployment_target will be ignored if there is platform. Because no version specified in s.platform = :ios, then the "iOS Deployment Target" setting of the CocoaPods generated target will be 4.3 which is the default value via CocoaPods.

Fixes #454

skywinder commented 4 years ago

thanks for quick response, @ElfSundae

skywinder commented 4 years ago

Thank you very much! I also update full spec with modern style! Much apreciated @ElfSundae 👍

ElfSundae commented 4 years ago

@skywinder No problem.

There is a slight issue in the new podspec file: ActionSheetPicker.h does not exist in the project root.

- spec.source_files = 'ActionSheetPicker.h', 'Pickers/*.{h,m}'
+ spec.source_files = 'Pickers/*.{h,m}'

And public_header_files can be omitted if all headers in source_files are considered public.

- spec.public_header_files = 'ActionSheetPicker.h', 'Pickers/*.h'
skywinder commented 4 years ago

@ElfSundae would you mind making new PR with this fix?

ElfSundae commented 4 years ago

Sure.