[BUG] - HIGH - Not working on screen rotation + Not working in Landscape

[StefaniOSApps]

Unfortunately I had to find out that the layout is destroyed when rotating under iOS 13. I have already checked it under 2.4.1 (from 2017) and also checked with develop branch with #379 . This error also exists with this version or with the develop branch.

I created a demo git so that you can easily reproduce it. https://github.com/StefaniOSApps/ActionSheet-Example

The error is shown in this video.

[StefaniOSApps]

@skywinder

[skywinder]

@StefaniOSApps Oh, got it. thanks for the mention and detailed description!

Rotations screen was always quite painfull for dynamic views. I thing the best way to quick fix now - is just hide picker when the screen is rotating. Thougs?

[StefaniOSApps]

This will not fix the problem. If you open the sheet in the landscape, it will already be extended incorrectly. This is shown in the GIF. @skywinder

[StefaniOSApps]

It will most likely be a method that is deprecated as of iOS 13.

[skywinder]

Can't realize, hot ti fix it in the right way. Looking forward to any suggestions.

[StefaniOSApps]

Hey, we need support. Any ideas? @xjki @BubiDevs @TimCinel, @kashifhisam or @delackner?

[Jack-s]

If it helps it looks like this is only an issue from the 2.4 release (2.3.1 seems to be fine). It also is an issue on iOS 12 as well so I don't think it's a iOS 13 specific issue.

[StefaniOSApps]

yes, it is most likely a bug generated by an iOS update.

[skywinder]

@Jack-s confirmed, in 2.3.1 it works. (it's simply dismisse picker)

@StefaniOSApps all that I can do now: to make an action, to dismiss the picker upon rotation. In most cases, it wouldn't be a problem. And I will preserve boolean trigger to switch off that behavior (with the warning, that developer do this at his own risk and it's not tested).

Thoughts?

[StefaniOSApps]

I don't think you have yet understood that the picker no longer works in the landscape. This is the main problem. You can also dismiss a picker by using your own methods.

see demo project https://github.com/StefaniOSApps/ActionSheet-Example @skywinder

[StefaniOSApps]

btw ... the video above was made with 2.3.1 @Jack-s @skywinder

Downloading dependencies
Installing ActionSheetPicker-3.0 2.3.1 (was 2.4.1 and source changed to `https://cdn.cocoapods.org/` from `trunk`)
Generating Pods project
Integrating client project
Pod installation complete! There is 1 dependency from the Podfile and 1 total pod installed.

[skywinder]

oh, crap. @StefaniOSApps I'm digging into it.

I tried to run on 2.3.1 - it works fine on ios 11 and ios 13. So will go deep into diff now.

ps. your project (https://github.com/StefaniOSApps/ActionSheet-Example) doesn't specify version: look at podfile: pod 'ActionSheetPicker-3.0'

so you still use the latest one.

p.s. hope your Energy Tracker doesn't affect too much. will do my best right now.

[skywinder]

Gotcha. @moheny changes brokes rotation logic. now it works. But I have to dismiss picker on iPhones during rotation. (for iPad it works as it was before)

[skywinder]

Fixed in 2.4.2 🎉

[skywinder]

rotation fixes in ACP looks like.. 😂 https://imgur.com/pdGY72I

[StefaniOSApps]

@skywinder the commit (change podfile) was not pushed. I have now pushed the changes (commit) I have now extensively tested it and it fixes the problem on 13.0. However, the Dismiss rotation is broken. We currently differentiate between iPad true and false. In the case of iPad == false, one could revise and solve with a transition delegate. I have now implemented this in my new project regardless of you in this way and it looks good. The rotation also looks clean.

[skywinder]

@StefaniOSApps Just dun your example. looks good.

What you mean, "Dismiss rotation is broken"? How does it look like? On iphone? Which position? Can you provide any steps to reproduce?

[StefaniOSApps]

use demo project from top. @skywinder

[skywinder]

oh, got it. in slow motion, I can see this. I will leave it as is for a while.

so, please let me know, if you know, how to solve this.

[skywinder]

Oh. I found that didn't reope it. @StefaniOSApps Does it persist in latest versions?