search

skywinder / ActionSheetPicker-3.0

Quickly reproduce the dropdown UIPickerView / ActionSheet functionality on iOS.
http://skywinder.github.io/ActionSheetPicker-3.0
BSD 3-Clause "New" or "Revised" License
3.4k stars 740 forks source link

ActionSheetStringPicker Popover Toolbar Cutoff for iOS 13 on iPads #470

Open herrchmafi opened 4 years ago

herrchmafi commented 4 years ago

The UIToolbar (in AbstractActionSheetPicker) gets cut off at the top for iOS 13 on iPads. Looking at the view hierarchy, it looks like the parent view placement isn't inset properly (should be positioned under caret).

@skywinder Thank you for your work!

pkccsb commented 4 years ago

Any update on this ticket?

skywinder commented 4 years ago

no, didn't check it

skywinder commented 4 years ago

If anyone knows how to reproduce and fix it - please, let me know

Algalish commented 4 years ago

@skywinder As far as I know - popovers are deprecated in iOS 9 and later. Your library is not working anymore on iPad for me so I went to AbstractActionSheetPicker.m file and changed the return for function "canShowPopover" to "NO" like that + (BOOL)canShowPopover { return NO; }

Since nobody uses iOS 9 or earlyer versions - I think it is safe to do it like this without conditions for the iOS version.

noorulain17 commented 3 years ago

@herrchmafi iOS 9 support has been dropped from ActionSheetPicker-3.0 -> 2.6.1 version. Please update the library to the latest version and let us know if the above issue still exists or not. Thanks