ActionSheetDatePicker still crash in Xcode12 when set the datePickerStyle

skywinder / ActionSheetPicker-3.0

Quickly reproduce the dropdown UIPickerView / ActionSheet functionality on iOS.

http://skywinder.github.io/ActionSheetPicker-3.0

BSD 3-Clause "New" or "Revised" License

3.4k stars 740 forks source link

ActionSheetDatePicker still crash in Xcode12 when set the datePickerStyle #498

Closed jolyot closed 4 years ago

jolyot commented 4 years ago

Updating my project in Xcode12, and using pod v2.5.1. https://github.com/skywinder/ActionSheetPicker-3.0/issues/492 is supposed to be resolved in this PR, but ActionSheetDatePicker still crash.

What did you do?

When set the datePcikerStyle in the same way as this example, crash occurs with this error message

libc++abi.dylib: terminating with uncaught exception of type NSException
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[ActionSheetDatePicker setDatePickerStyle:]: unrecognized selector sent to instance 0x158c1e070'
terminating with uncaught exception of type NSException

What did you expect to happen?

ActionSheetDatePicker does crash in Xcode12 when set the datePickerStyle

Environment

ActionSheetPicker_3_0 version: 2.5.1 Xcode version: 12.0 beta5

noorulain17 commented 4 years ago

I had tested this on Xcode 12.0 beta 1, will check again on Xcode 12.0 beta 6 (as it's the latest) & update you.

noorulain17 commented 4 years ago

@jolyot I updated ActionSheetPicker-3.0 to version 2.5.1 in a new sample project. Tried on both Xcode 12.0 beta 1 & Xcode 12.0 beta 6 on simulators of iOS 13.4 & 14.0 with the sample code that you've mentioned above, app is working fine without any crash.

Can you please try updating the pod again? If the crash is still reproduced, please post a video/screenshot of it.

jolyot commented 4 years ago

@noorulain17

Can you please try updating the pod again? If the crash is still reproduced, please post a video/screenshot of it.

OK! I will try!

noorulain17 commented 4 years ago

Hey @jolyot , Any update on the issue?

jolyot commented 4 years ago

@noorulain17 Sorry for the late reply. I tried with Xcode12GM seed. It does not crash! But layout is a little bit broken in iOS14 simulator.

datePickerStyle is automatic	datePickerStyle is wheels

However, this issue is about the crash in Xcode12 and it does not occur in Xcode GM seed. So, I think this issue has been resolved.

noorulain17 commented 4 years ago

Thanks @jolyot for the update. Yes I've also noticed the broken layout in the latest Xcode version. I've started working on it and will soon release another stable version.

jolyot commented 4 years ago

@noorulain17

I've started working on it and will soon release another stable version.

OK! I hope it will release soon!