update deprecated classes: UIPopoverPresentationController

skywinder / ActionSheetPicker-3.0

Quickly reproduce the dropdown UIPickerView / ActionSheet functionality on iOS.

http://skywinder.github.io/ActionSheetPicker-3.0

BSD 3-Clause "New" or "Revised" License

3.4k stars 740 forks source link

update deprecated classes: UIPopoverPresentationController #499

Closed cutmail closed 4 years ago

cutmail commented 4 years ago

This PR does 3 things:

Apply recommended settings for Xcode 12.
Change minimum deployment target from iOS 8.0 to iOS 9.0 since Xcode 12 dropped support for iOS 8.0.
Replace UIPopoverController with UIPopoverPresentationController to fix deprecated warnings.

noorulain17 commented 4 years ago

@cutmail Thank you for this PR. I checked out your branch, there are some warnings in CoreActionSheetPicker code that needs to be catered before dropping support for iOS 9.0. Please update your PR after fixing those warnings.

skywinder commented 4 years ago

thanks for update, @cutmail agree with @noorulain17: To complete this PR, please make changes in example projects to remove warnings and make whole project consistent so we can merge your PR!

skywinder commented 4 years ago

@cutmail is there any updates?

cutmail commented 4 years ago

@skywinder Sorry for late, I'm fixing warnings!

skywinder commented 4 years ago

thanks for update, @cutmail 👍

@noorulain17 please, have a look. looks legit.

noorulain17 commented 4 years ago

Thanks @cutmail. Looks good.

@skywinder I'll test this tonight.

noorulain17 commented 4 years ago

@cutmail / @skywinder tested. Looks fine. I think we're good to merge. Just need to rebase it with latest develop branch

noorulain17 commented 4 years ago

@cutmail please rebase your branch with skywinder:develop

cutmail commented 4 years ago

@noorulain17 Sorry for late, I rebased branch. Please check.

skywinder commented 4 years ago

Yes, looks very nice, thank you!