Closed joeboyscout04 closed 8 months ago
Thanks for the contribution @joeboyscout04 🎉
Please share a video representing the fix with all datePickerStyle
s
Here's some videos which I took showing the results. Please forgive the low video quality, I had to compress them pretty hard as I can only upload max 10mb videos here at Github. I modified the demo project to do the testing.
Here's the original behavior. Note that in .compact
and .inline
styles, tapping some date dismisses the picker rather than selecting the date.
In the new behavior, you should be able to select a date in all datePickerStyles
Here's the new behavior on iPad (popover).
@joeboyscout04 Thanks! 🎉
There would be a problem when the superview
is not full-screen size.
We can disable the gesture in gestureRecognizerShouldBegin:
.
Fixes https://github.com/skywinder/ActionSheetPicker-3.0/issues/532 .
It looks like the issue was introduced in https://github.com/skywinder/ActionSheetPicker-3.0/pull/528, where the tap gesture was moved to the window. The action sheet itself also needs to be exempted from the dismissal tap gesture to work with a
datePickerStyle = .inline
.