search

skywinder / ActionSheetPicker-3.0

Quickly reproduce the dropdown UIPickerView / ActionSheet functionality on iOS.
http://skywinder.github.io/ActionSheetPicker-3.0
BSD 3-Clause "New" or "Revised" License
3.4k stars 740 forks source link

Fix Memory Leak & Fix import #561

Closed mlch911 closed 7 months ago

mlch911 commented 9 months ago

Fix import using CocoaPods. Fix dismiss function not called in iPad. Fix Memory Leak.

skywinder commented 8 months ago

Thanks for the update, @mlch911!

I am no longer supporting this library, as I am now 100% focused on blockchain R&D and audits at my company, where I dedicate all my time www.oxor.io.

I appreciate your willingness to help with the project. I can add you to the list of contributors, so you can keep it alive if you're willing to continue its development.

P.S. Here is an update about adding collaborators. Ping me if you're willing to keep it going. https://github.com/skywinder/ActionSheetPicker-3.0/issues/348

Wei18 commented 7 months ago

Hi @mlch911, Please fix conflicts, thanks.

mlch911 commented 7 months ago

Thanks for the update, @mlch911!

I am no longer supporting this library, as I am now 100% focused on blockchain R&D and audits at my company, where I dedicate all my time www.oxor.io.

I appreciate your willingness to help with the project. I can add you to the list of contributors, so you can keep it alive if you're willing to continue its development.

P.S. Here is an update about adding collaborators. Ping me if you're willing to keep it going. #348

Would be nice to help. Sorry for the late reply. @skywinder

mlch911 commented 7 months ago

Hi @mlch911, Please fix conflicts, thanks.

@Wei18 Done.

Wei18 commented 7 months ago

We still need fix warns (about import) after this PR merged.

mlch911 commented 7 months ago

We still need fix warns (about import) after this PR merged.

I have modified the import method. Do I need to change it again?

Wei18 commented 7 months ago

We still need fix warns (about import) after this PR merged.

I have modified the import method. Do I need to change it again?

It's ok. Some users who partially use Cocoapods encountered errors. Your recent changes have turned these errors into warnings, so we can address these warnings later.

mlch911 commented 7 months ago

We still need fix warns (about import) after this PR merged.

I have modified the import method. Do I need to change it again?

It's ok. Some users who partially use Cocoapods encountered errors. Your recent changes have turned these errors into warnings, so we can address these warnings later.

I encountered these errors too. So I changed it.

Wei18 commented 7 months ago

We still need fix warns (about import) after this PR merged.

I have modified the import method. Do I need to change it again?

It's ok. Some users who partially use Cocoapods encountered errors. Your recent changes have turned these errors into warnings, so we can address these warnings later.

I encountered these errors too. So I changed it.

Could you provide workspace_example.zip and information about (xcode version, coaoapod version), let me reproduce this issue. I wanna update CI_build.yml .

mlch911 commented 7 months ago

We still need fix warns (about import) after this PR merged.

I have modified the import method. Do I need to change it again?

It's ok. Some users who partially use Cocoapods encountered errors. Your recent changes have turned these errors into warnings, so we can address these warnings later.

I encountered these errors too. So I changed it.

Could you provide workspace_example.zip and information about (xcode version, coaoapod version), let me reproduce this issue. I wanna update CI_build.yml .

Xcode 15.2, Cocoapods 1.11.3, haven't run pod install. I Just use the Demo Project ActionSheetPicker-3.0.xcworkspace. At this commit 6a913a7ca489a8565afcf85c62a5a9d055934711 and build.

image
Wei18 commented 7 months ago

We still need fix warns (about import) after this PR merged.

I have modified the import method. Do I need to change it again?

It's ok. Some users who partially use Cocoapods encountered errors. Your recent changes have turned these errors into warnings, so we can address these warnings later.

I encountered these errors too. So I changed it.

Could you provide workspace_example.zip and information about (xcode version, coaoapod version), let me reproduce this issue. I wanna update CI_build.yml .

Xcode 15.2, Cocoapods 1.11.3, haven't run pod install. I Just use the Demo Project ActionSheetPicker-3.0.xcworkspace. At this commit 6a913a7ca489a8565afcf85c62a5a9d055934711 and build. image