search

skywinder / GaugeKit

Kit for building custom gauges + easy reproducible Apple's style ring gauges.
https://www.cocoacontrols.com/controls/gaugekit
MIT License
1.03k stars 100 forks source link

Gradient Circle #35

Closed sinanku closed 4 years ago

sinanku commented 8 years ago

gradient

sinanku commented 8 years ago

@skywinder It looks like it's complaining about these two lines

super.init(coder: aDecoder) and gaugeLayer = getGauge(rotateAngle: rotate / 10 * M_PI)

which I changed to

super.init(coder: aDecoder)! and gaugeLayer = getGauge(rotate / 10 * M_PI)

Current project won't compile without the changes I made to run locally, thoughts?

skywinder commented 8 years ago

@sinanulkuatam your example looks pretty good! But what the reason to force eusers run pod install? why not just add it as internal framework? About errors: please wait for merge of #32, I hope it will not make merge conflicts. It should remove some problems and will update syntax a bit

sinanku commented 8 years ago

@skywinder yes you're right about adding it as an internal framework, I'll make that change today

sinanku commented 8 years ago

@skywinder a couple changes, I removed the Pods and all dependencies around the build for it. I had a couple issues embedding it directly as it pointed to my own derived data, so instead of running Example.xcodeproj you can run GaugeKit.xcworkspace as it was originally suggested on the readme and change your scheme to run the example. I will update the docs to take this into account.

sinanku commented 8 years ago

@skywinder let me know if there are any issues with the branch/PR

skywinder commented 8 years ago

There is also broken test in this build: https://travis-ci.org/skywinder/GaugeKit/builds/131408468#L310

" Missing argument label 'rotateAngle:' in call"

skywinder commented 8 years ago

Thank you for PR. And sorry for late reply. The project is moved to Swift 3. I would like to review your changes if you will able to synchronize it with current version.

sinanku commented 8 years ago

I will have time later this week to work on it, thanks for the update!

skywinder commented 6 years ago

I'd be more than happy to merge a PR adding this feature, it seems like it would be useful for sure 👍 Please let me know, you going to update it to up-to date version and fix minor things!

sinanku commented 6 years ago

@skywinder I'll be able to take a look in a few weeks, wrapping up grad school at the moment!

skywinder commented 4 years ago

CLosed in favor of #68