search

skywrite / sky-tumblr-export

Export your Tumblr blog into Markdown. Use it with Sky if you like.
MIT License
59 stars 10 forks source link

Broken in Node v0.10.7 #3

Closed sockdrawermoney closed 11 years ago

sockdrawermoney commented 11 years ago

Error in Node .10.7:

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: spawn ENOENT
    at errnoException (child_process.js:980:11)
    at Process.ChildProcess._handle.onexit (child_process.js:771:34)

vs.

Error in Node v0.8.23:

/usr/local/share/npm/lib/node_modules/sky-tumblr-export/bin/sky-tumblr-export:156
        mdp.markdown = util.format('**[ERROR: sky-tumblr-export: %s]**',err)
                       ^
ReferenceError: util is not defined
    at /usr/local/share/npm/lib/node_modules/sky-tumblr-export/bin/sky-tumblr-export:156:24
    at ChildProcess.<anonymous> (/usr/local/share/npm/lib/node_modules/sky-tumblr-export/node_modules/pdc/pandoc.js:29:14)
    at ChildProcess.EventEmitter.emit (events.js:99:17)
    at Process._handle.onexit (child_process.js:680:10)

which is still broken, but more helpful (looking into this one now)

jprichardson commented 11 years ago

Wow, thanks for all of the help. I can get this all merged and fixed by Friday at the latest. I suspect the v0.10 error may have something to do with batchflow. The latest batchflow is v0.4.0 and is Node v0.10 compatible.

I'll try to get to this tonight, but i don't see that quite happening until later in the week.

sockdrawermoney commented 11 years ago

Cool!

As I expected, the util is not defined error was easily fixed by requiring util.

I got a little farther and then ran into this issue in markdown-page.

jprichardson commented 11 years ago

Cool, I'm a bit curious on the cause of the problems and with the recent sale of Tumblr to Yahoo, I'm sure there will be a lot of people who want to leave Tumblr, so I'll check all of this out.

jprichardson commented 11 years ago

Did an update. Tested with your blog and it seems that it's working with the exception of some titles being reported as "null/undefined". Give it a shot and let me know what issues you run into or how well it's working.

sockdrawermoney commented 11 years ago

Awesome! :) I'll check it out.

sockdrawermoney commented 11 years ago

From what I can tell, here's the pattern of incomplete results (which all in all aren't that big of a dealt)

Tumblr lets you write posts that don't have titles at all: those are getting a null output, which is fine, and probably the correct result.

The ones that are getting undefined are all quotes or video embeds. Would be nice if it was pulling that content, but it's really awesome that it handles the core purpose (articles) just peachy. :)

Thanks again!

jprichardson commented 11 years ago

Try it now if you haven't already migrated. I've updated support for links, photos, and videos.