sl-design-system / components

SL Design System
https://sanomalearning.design/
Apache License 2.0
42 stars 4 forks source link

Breadcrumb Style not compatible/accessible with Magister Theme #1348

Open MDWSanoma opened 4 months ago

MDWSanoma commented 4 months ago

Provide a general summary of the issue here

The Breadcrumb style in Magister Themes are not compatible with the Designs of Magister Screens. We're now using a page header with a dark background, and we'd like the breadcrumbs to be white, not light blue and primary blue as it is now in Dark mode.

🤔 Expected Behavior?

Screenshot 2024-06-18 at 10 56 30

Option for high-contrast (white) text for the text

😯 Current Behavior

Magister Light:

Screenshot 2024-06-18 at 10 57 43

Magister Dark:

Screenshot 2024-06-18 at 10 58 51

Neither of these are compatible, or accessible.

(There's also a weird bug with the first level, styling is off)

💁 Possible Solution

Option for a high contrast (white) version for the page header designs with a dark background. We'd still need a version as it is now for the current screens that have a white page header (no background)

See: https://www.figma.com/design/o1ZlCUh6LyicB6xBu2GRmC/branch/XDZXzzzZYkLskuT8BM5nbE/DNA-Library?m=auto&node-id=0-1623&t=H7MDq4KSp6ot9s46-1 (We're now still using our own breadcrumb component)

📷 Screenshots

No response

📎 Link to Figma

https://www.figma.com/design/YZeBneflpJkX3KXSyvMrqP/Magister-Light-mode?m=auto&node-id=1765-1464&t=CXAqrzMPwmtfVQ2o-1

🎨 Your Theme(s)

Magister

### Tasks
- [ ] https://github.com/sl-design-system/components/issues/1405
### CFA Interest
- [ ] Magister
DanielleRameau commented 4 months ago

@MDWSanoma Roald is currently not here, we will discuss this topic next week during the refinement together with him. This issue doesn't only affect the breadcrumbs but other components as well so we have to implement this 'on dark' feature within our epics 'provide more context in tokens'.

DanielleRameau commented 3 months ago

@MDWSanoma we created a new story to take a look at a ondark property, see #1405 it's on the backlog. Once that is ready we can work on this.