search

sl-design-system / components

SL Design System
https://sanomalearning.design/
Apache License 2.0
43 stars 4 forks source link

[Button Bar] Set standard variants #1437

Open jtalen opened 3 months ago

jtalen commented 3 months ago

Provide a general summary of the issue here

In the sizes MD and LG some of the buttons have the wrong font family.

image

image

🤔 Expected Behavior?

All buttons should be the same, because it should be the same component. But half of all the buttons have the wrong font family. It should be 'Open Sans'

😯 Current Behavior

2 of 4 buttons MD and LG are 'Source Sans Pro'.

💁 Possible Solution

Use the same button component for all buttons in the button bar. And don't overwrite them...

📷 Screenshots

No response

📎 Link to Figma

https://www.figma.com/design/YZeBneflpJkX3KXSyvMrqP/Magister-Light-mode?m=auto&node-id=1919-103221&t=yLgn0JmjguMWTG8T-1

🎨 Your Theme(s)

Magister

### Tasks
- [x] Apply tokens again and check all variants.
- [ ] Set standard variants within the themes.
DanielleRameau commented 2 months ago

I did a quick fix to help Magister out. In the theme, we implemented the most common magister bar so they don't have to change the buttons inside.

Current issue:

When you change the button variant after inserting the content the content will be lost after switching the variant. To solve this we need to set standard variants within the themes.