slab / quill

Quill is a modern WYSIWYG editor built for compatibility and extensibility
https://quilljs.com
BSD 3-Clause "New" or "Revised" License
43.52k stars 3.38k forks source link

Error building quilljs for development locally #1174

Closed justiceo closed 7 years ago

justiceo commented 7 years ago

Running the command 'npm run build' throws an error with webpack.

Below is the full error log:

====== Begin Error ====== webpack --config _develop/webpack.config.js; rm dist/quill.core dist/quill.bubble dist/quill.snow;

module.js:327 throw err; ^

Error: Cannot find module 'C:\Users\Me\Code\Redactor\quill2_develop\webpack.config.js;' at Function.Module._resolveFilename (module.js:325:15) at Function.Module._load (module.js:276:25) at Module.require (module.js:353:17) at require (internal/module.js:12:17) at module.exports (C:\Users\Me\Code\Redactor\quill2\node_modules\webpack\bin\convert-argv.js:80:13) at Object. (C:\Users\Me\Code\Redactor\quill2\node_modules\webpack\bin\webpack.js:39:40) at Module._compile (module.js:409:26) at Object.Module._extensions..js (module.js:416:10) at Module.load (module.js:343:32) at Function.Module._load (module.js:300:12)

npm ERR! Windows_NT 10.0.10586 npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "run" "build" npm ERR! node v4.5.0 npm ERR! npm v2.15.9 npm ERR! code ELIFECYCLE npm ERR! quill@1.1.6 build: webpack --config _develop/webpack.config.js; rm dist/quill.core dist/quill.bubble dist/quill.snow; npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the quill@1.1.6 build script 'webpack --config _develop/webpack.config.js; rm dist/quill.core dist/quill.bubble dist/quill.snow;'. npm ERR! This is most likely a problem with the quill package, npm ERR! not with npm itself. npm ERR! Tell the author that this fails on your system: npm ERR! webpack --config _develop/webpack.config.js; rm dist/quill.core dist/quill.bubble dist/quill.snow; npm ERR! You can get information on how to open an issue for this project with: npm ERR! npm bugs quill npm ERR! Or if that isn't available, you can get their info via: npm ERR! npm ERR! npm owner ls quill npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request: npm ERR! C:\Users\Me\Code\Redactor\quill2\npm-debug.log

====== End Error ======

When I run the culprit commands webpack --config _develop/webpack.config.js; rm dist/quill.core dist/quill.bubble , they succeed however.

Steps for Reproduction

  1. Cone quilljs master from github.com/quilljs/quilljs
  2. Confirm npm and ruby is installed and up to date
  3. run 'npm install' - which should complete successfully
  4. run 'gem ....' which should complete successfully
  5. run 'npm run build' and the error above should happen

Expected behavior: The source should be compiled to a dist directory and a server started at localhost for accessing the examples

Actual behavior: The build doesn't complete

Platforms: Tried both widows and linux.

Version: Fresh installs of nodejs, npm, and ruby gem

jhchen commented 7 years ago

From the error message:

Error: Cannot find module 'C:\Users\Me\Code\Redactor\quill2_develop\webpack.config.js;'

It seems the problem is the path is being concatenated into quill2_develop. Why this is happening on Windows I'm not sure. I spun up a DigitalOcean instance of Ubuntu 16.04 and everything builds as expected.

justiceo commented 7 years ago

Yes I tried it on Ubuntu 16 and it worked as well. But why not Ubuntu 14 and Windows (10)?

jhchen commented 7 years ago

Ubuntu 14.04 on a fresh DigitalOcean instance works for me too... Can you paste the error you get on your Ubuntu install?

justiceo commented 7 years ago

Okay, here is the ubuntu error log

npm ERR! Linux 3.13.0-24-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "start"
npm ERR! node v6.9.2
npm ERR! npm  v3.10.9
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! quill@1.1.6 start: `npm run build; foreman start -f _develop/procfile`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the quill@1.1.6 start script 'npm run build; foreman start -f _develop/procfile'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the quill package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build; foreman start -f _develop/procfile
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs quill
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls quill
npm ERR! There is likely additional logging output above.
jhchen commented 7 years ago

What happens when you run which node?

justiceo commented 7 years ago

$which node returns /usr/bin/node $/usr/bin/node --version returns v6.9.2

jhchen commented 7 years ago

Can you post the output for npm run build. If that fails can you also post the output for ./node_modules/.bin/webpack --config _develop/webpack.config.js

quill-bot commented 7 years ago

Closing inactive issue.

saitaiky commented 7 years ago

I have the same issues as well... any solutions?

saitaiky commented 7 years ago

0 info it worked if it ends with ok 1 verbose cli [ 'C:\Program Files\nodejs\node.exe', 1 verbose cli 'C:\Users\user2\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js', 1 verbose cli 'run', 1 verbose cli 'build' ] 2 info using npm@5.3.0 3 info using node@v6.11.2 4 verbose run-script [ 'prebuild', 'build', 'postbuild' ] 5 info lifecycle quill@1.3.1~prebuild: quill@1.3.1 6 info lifecycle quill@1.3.1~build: quill@1.3.1 7 verbose lifecycle quill@1.3.1~build: unsafe-perm in lifecycle true 8 verbose lifecycle quill@1.3.1~build: PATH: C:\Users\user2\AppData\Roaming\npm\node_modules\npm\bin\node-gyp-bin;C:\Users\user2\Documents\investment-sys\node_modules\quill\node_modules.bin;C:\Users\user2\Documents\investment-sys\node_modules.bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Program Files\nodejs\;C:\Users\user2\AppData\Local\Microsoft\WindowsApps;C:\Users\user2\AppData\Local\atom\bin;C:\Users\user2\AppData\Roaming\npm;C:\Users\user2\AppData\Local\GitHubDesktop\bin 9 verbose lifecycle quill@1.3.1~build: CWD: C:\Users\user2\Documents\investment-sys\node_modules\quill 10 silly lifecycle quill@1.3.1~build: Args: [ '/d /s /c', 10 silly lifecycle 'webpack --config _develop/webpack.config.js; rm dist/quill.core dist/quill.bubble dist/quill.snow;' ] 11 silly lifecycle quill@1.3.1~build: Returned: code: 1 signal: null 12 info lifecycle quill@1.3.1~build: Failed to exec build script 13 verbose stack Error: quill@1.3.1 build: webpack --config _develop/webpack.config.js; rm dist/quill.core dist/quill.bubble dist/quill.snow; 13 verbose stack Exit status 1 13 verbose stack at EventEmitter. (C:\Users\user2\AppData\Roaming\npm\node_modules\npm\lib\utils\lifecycle.js:289:16) 13 verbose stack at emitTwo (events.js:106:13) 13 verbose stack at EventEmitter.emit (events.js:191:7) 13 verbose stack at ChildProcess. (C:\Users\user2\AppData\Roaming\npm\node_modules\npm\lib\utils\spawn.js:40:14) 13 verbose stack at emitTwo (events.js:106:13) 13 verbose stack at ChildProcess.emit (events.js:191:7) 13 verbose stack at maybeClose (internal/child_process.js:891:16) 13 verbose stack at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5) 14 verbose pkgid quill@1.3.1 15 verbose cwd C:\Users\user2\Documents\investment-sys\node_modules\quill 16 verbose Windows_NT 10.0.14393 17 verbose argv "C:\Program Files\nodejs\node.exe" "C:\Users\user2\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js" "run" "build" 18 verbose node v6.11.2 19 verbose npm v5.3.0 20 error code ELIFECYCLE 21 error errno 1 22 error quill@1.3.1 build: webpack --config _develop/webpack.config.js; rm dist/quill.core dist/quill.bubble dist/quill.snow; 22 error Exit status 1 23 error Failed at the quill@1.3.1 build script. 23 error This is probably not a problem with npm. There is likely additional logging output above. 24 verbose exit [ 1, true ]

saitaiky commented 7 years ago

When I tried to install those dependence, I got this error. npm install npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.1.2 (node_modules\fsevents): npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

adeguntoro commented 6 years ago

still not solved ? because i have same issue.

ls-tn commented 6 years ago

Same here. No wonder it doesn't find the webpack.config.js file as the entire _develop directory is missing. Error: Cannot find module '/Users/msh/Documents/projects/mindscope/node_modules/quill/_develop/webpack.config.js' I installed Quill as a node module (current, 1.3.6) with a simple npm i quill --save.

Is the _develop directory supposed to be in there?

Anyway, copied the directory with files from the repo, did an nom install and now this:

TypeError: Cannot destructure property `createHash` of 'undefined' or 'null'.
    at Object.<anonymous> (/Users/msh/Documents/projects/mindscope/node_modules/quill/node_modules/mini-css-extract-plugin/dist/index.js:26:44)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/msh/Documents/projects/mindscope/node_modules/quill/node_modules/mini-css-extract-plugin/dist/cjs.js:3:18)
    at Module._compile (module.js:652:30)

It would be nice if the npm module would build normally.