Add ability to resize videos that are inserted

[guateandrew]

This was previously raised in #1283 and closed. I'm still not finding a particularly satisfactory way to set height and width of videos (which currently display really small).

Attempt one This was suggested in #1283. I added height and width attributes to ql-video. Problem for me is that I am using Quill to create content that might have various # of columns, so fixed pixels wont work for me. I need percentages, and I need the height to be a percentage of the width. I can't do this with pure CSS on the iframe element. I could do this if someone could help me understand how to modify the Video blot to wrap the iframe in another classed div.

Attempt two Taking inspiration from the word count tutorial I created a module which listened for changes and then looked for all the ql-video divs, set their width to 100%, then measured that width in pixels then set the height to 56% of the width (for 16:9 aspect ratio). Seemed like overkill at the time but hey. Problem was that this style information isn't saved with the content and so when Quill is rendered a second time, well my height and width and blown away.

Attempt three Merged an open pull request to add this functionality to quill-image-resize module. Super promising, but could seem to get the modified plugin working (it exported the iFrame resize module is undefined.

Any help appreciated.And adding my vote that image/video resizing should probably be part of core, I would have though it was not an uncommon use case.

[Anoiing]

I want to set the video autoplay false and loop false , any one have some ideas?

[jhchen]

You can create an embed blot with whatever structure you want so going off attempt 1 you can do: https://codepen.io/quill/pen/OxbqbQ. Then not sure what CSS things you had in mind.

[lancetipton]

I made a little repo to allow video resize with iframe. I just started messing with Quill this week, so there may be better ways to do it, but it works so that's nice.

https://github.com/lancetipton04/quill-video-resize

[wisteria-hill-technologies]

@lancetipton Thank you for that. I tested it with a react component. It works! But, texts get wrapped up inside the iframe... Is there anyway to prevent this?

[lancetipton]

@nfabacus I'm not sure what you mean by text get wrapped up inside the iframe. Can you show me an example?

[wisteria-hill-technologies]

@lancetipton Here is what I mean

Also, what is the best way to disable the video resize mode? Even if I make the editor readonly, resize does not stop and I cannot click to play the video. Any hint will be appreciated.

Here is my repo: quill-video-resize branch https://github.com/nfabacus/react-quill-experiment/tree/quill-video-resize

Thank you

[lancetipton]

hmm.. does not seem to be happening to me. Let me take a look and see what I find.

[lancetipton]

@nfabacus Just submitted a pull request to your repo. Let me know if that fixes if for you.

[wisteria-hill-technologies]

@lancetipton Yes, I just checked the branch. It works! Thank you very much for fixing the issue. I will study what you did with the code.

[francois-m]

@guateandrew Yes, you can get the height to be a percentage of the width with CSS, not directly on the iframe element, but on surrounding divs, like this:

<div style="width:100%">
   <div style="height:0px; padding-bottom:56.25%; position:relative;">
      <iframe src="..." style="position:absolute; left:0px; top:0px; width:100%; height:100%;"></iframe>
   </div>
</div>

Here, the 56.25% represents the 16/9 proportion.

[zdraganov]

Any working open source module for resizing embedded videos? I tried many options, but without luck :(

[jaskiratr]

For responsive embedding If it helps anyone I'm using JS to add a container to .ql-video elements and styling them with CSS

var videos = document.querySelectorAll('.ql-video')
for (let i = 0; i < videos.length; i++) {
  var embedContainer = document.createElement('div')
  embedContainer.setAttribute('class', 'embed-container')
  var parent = videos[i].parentNode
  parent.insertBefore(embedContainer, videos[i])
  embedContainer.appendChild(videos[i])
}

.embed-container 
  position: relative
  padding-bottom: 56.25%
  height: 0
  overflow: hidden
  max-width: 100%

.embed-container iframe, .embed-container object, .embed-container embed
  position: absolute
  top: 0
  left: 0
  width: 100%
  height: 100%

[ewingrj]

following up on the above responsive embedding post, you can create a custom wrapper Blot and use the above css:

import Quill from 'quill'

const QuillVideo = Quill.import('formats/video')
const BlockEmbed = Quill.import('blots/block/embed')

const VIDEO_ATTRIBUTES = ['height', 'width']

// provides a custom div wrapper around the default Video blot
class Video extends BlockEmbed {
  static create (value) {
    const iframeNode = QuillVideo.create(value)
    const node = super.create()
    node.appendChild(iframeNode)
    return node
  }

  static formats (domNode) {
    const iframe = domNode.getElementsByTagName('iframe')[0]
    return VIDEO_ATTRIBUTES.reduce(function (formats, attribute) {
      if (iframe.hasAttribute(attribute)) {
        formats[attribute] = iframe.getAttribute(attribute)
      }
      return formats
    }, {})
  }

  static value (domNode) {
    return domNode.getElementsByTagName('iframe')[0].getAttribute('src')
  }

  format (name, value) {
    if (VIDEO_ATTRIBUTES.indexOf(name) > -1) {
      if (value) { this.domNode.setAttribute(name, value) }
      else { this.domNode.removeAttribute(name) }
    }
    else { super.format(name, value) }
  }
}

Video.blotName = 'video'
Video.className = 'ql-video-wrapper'
Video.tagName = 'DIV'

Quill.register(Video, true)

note: I set the className to ql-video-wrapper instead of embed-container so adjust the css accordingly

[preteambuy]

I want to set the video autoplay false and loop false , any one have some ideas?

Did u figure it out?

[grafxflow]

The problem I am getting with the above once it has been saved and I go back to edit the content it seems to removes the 'ql-video-wrapper' classes and div container?

[BOTOOM]

try use this module , is updated to work with the latest version of quil

https://www.npmjs.com/package/@botom/quill-resize-module

[BullPointer]

try use this module , is updated to work with the latest version of quil

https://www.npmjs.com/package/@botom/quill-resize-module This module returns this error: net::ERR_ABORTED 504 (Outdated Optimize Dep) What solution or other recommendation do you have?

[BOTOOM]

try use this module , is updated to work with the latest version of quil https://www.npmjs.com/package/@botom/quill-resize-module This module returns this error: net::ERR_ABORTED 504 (Outdated Optimize Dep) What solution or other recommendation do you have?

Can you tell me how you implemented it so I can try to replicate it?

[BullPointer]

I'm sorry for not letting you aware that it worked fine after restarting my project. Thanks!

On Thu, Oct 12, 2023 at 1:56 PM Edwar Diaz @.***> wrote:

try use this module , is updated to work with the latest version of quil @.***/quill-resize-module This module returns this error: net::ERR_ABORTED 504 (Outdated Optimize Dep) What solution or other recommendation do you have?

Can you tell me how you implemented it so I can try to replicate it?

— Reply to this email directly, view it on GitHub https://github.com/quilljs/quill/issues/1707#issuecomment-1760098155, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWBV5KMMJFYNFUXVTA66A73X7AVLXAVCNFSM4D3WN6N2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZWGAYDSOBRGU2Q . You are receiving this because you commented.Message ID: @.***>

[quill-bot]

Quill 2.0 has been released (announcement post) with many changes and fixes. If this is still an issue please create a new issue after reviewing our updated Contributing guide :pray: