slab / quill

Quill is a modern WYSIWYG editor built for compatibility and extensibility
https://quilljs.com
BSD 3-Clause "New" or "Revised" License
43.52k stars 3.38k forks source link

Type error in indent.d.ts #3940

Closed pablopla closed 9 months ago

pablopla commented 9 months ago

I'm getting an error when trying to build Quill2.0-beta.0 with an Angular 17 project using Webpack or esbuild:

Actual behavior:

✘ [ERROR] TS2416: Property 'value' in type 'IndentAttributor' is not assignable to the same property in base type 'ClassAttributor'.
  Type '(node: any) => number' is not assignable to type '(node: HTMLElement) => string'.
    Type 'number' is not assignable to type 'string'. [plugin angular-compiler]

    node_modules/quill/formats/indent.d.ts:5:4:
      5 │     value(node: any): number | undefined;
        ╵     ~~~~~

Platforms: Webpack or esbuild

Version: v2.0.0-beta.0

luin commented 9 months ago

Fixed in 2.0.0-beta.1. Thanks for reporting this!