when input(not IME) after inline embed element, selection do not update - Githubissues

slab / quill

Quill is a modern WYSIWYG editor built for compatibility and extensibility

https://quilljs.com

BSD 3-Clause "New" or "Revised" License

43.18k stars 3.35k forks source link

when input(not IME) after inline embed element, selection do not update #4065

Open wpj-wpj-wpj opened 6 months ago

wpj-wpj-wpj commented 6 months ago

https://github.com/quilljs/quill/assets/26898312/d9db1641-53a7-41e8-a5f3-2e344edfb101

How to produce:

when inline embed element is at end of line, input after it
or set the cursor by click at the end of the inline embed element, then input. it don't work everytime,the trick is to click very close to the end of embed element. i guess the cause is click on the rightGuard of the embed element which is zero-width.

Debug:

when input after embed element, quill will excute twice setNativeRange:

optimize listener: https://github.com/quilljs/quill/blob/main/packages/quill/src/core/selection.ts#L106
update listener: https://github.com/quilljs/quill/blob/main/packages/quill/src/core/selection.ts#L82-L87

optimize set the expected range from context

update set the wrong range

How to fix:

update should share the same context with optimize
when context.range exist which means optimize will handle the range, update should not setNativeRange

wpj-wpj-wpj commented 6 months ago

I've oppened PR https://github.com/quilljs/quill/pull/4066