slabbi / uddeIM

udde Instant Messages (uddeIM) - Instant Messages System for Mambo and Joomla
12 stars 8 forks source link

uddeIM5.3 works fine - thanks a lot #57

Closed jojo12 closed 2 months ago

jojo12 commented 2 months ago

Do you will put it in the JED? with slabbi

slabbi commented 2 months ago

Yes, my JED account works again

slabbi commented 2 months ago

Have you committed all changes? I don't see these.

slabbi commented 2 months ago

Cannot upload the zip you have created to JED since it has not a proper structure:

It should look like this: grafik

The zip files can be installed and contain a proper install script. You should also push your changes to the repository.

jojo12 commented 2 months ago

I only tried to write a review. This is, what I can. I didn't upload something. I?ve not the rights. The link is to your site and there is no uddeIM 5.3. You should change this! Greetings Jojo

jojo12 commented 2 months ago

Does it work on Joomla! 4?

jojo12 commented 2 months ago

@slabbi: to whoom are you writing?

slabbi commented 2 months ago

To @joomod :)

joomod commented 2 months ago

@slabbi sorry, I have not commited the changes of my releases, as I couldn't find out how to publish a release package in the main structure folder, where I can pick single files (I told, I'm new to github :)

I think the folder structure is not the main problem for JED. I just run a test with JED checker and got a big list of errors and warnings (ok, many, many come from the 3rd party addons, which I have not checked for J5)

I will go and try to fix the errors in the main component and modules/plugins first, then we can talk about the xml errors (e.g. update server, name etc.)

it would be great if I could have helped to release an official component (starting from updating it just for my own purpose)

jed

slabbi commented 2 months ago

Commit to "_uddeIM5_for_Joomla5_UNSUPPORTED" I will rename this folder finally to "_uddeIM for Joomla 5.x", so that it contains the J5 code. The files outside that folder should be untouched because these are J1-J4 compatible.

joomod commented 2 months ago

I have finished v5.3.5 which completes the JED check without errors (includes update ReCaptcha lib to actual version 1.3) also I added an update server here on github and created a uddeim_update.xml the 3rd party folder is deleted, because most won't run on J5 or I couldn't handle the errors

uddeIM_5.3.5-j5.zip uddeim_update.zip

check it out

uddeim5 3 5

slabbi commented 2 months ago

Can you check this file, plz? uddeIM_5.3_j50_unzip1st.zip The scripts to build this archive are in TOOLS. You need 7-zip only.

joomod commented 2 months ago

looks good, only the admin.includes.php (I have edit the uploaded file) should be replaced by this (new string in the createCFGstring) $cf.="defined('_JEXEC') or die( 'Direct Access to this location is not allowed.' );\n"; so the config.class stays correct for the JEXEC check

admin.includes.zip

joomod commented 2 months ago

just the main changes for v5.0 (to be added in changelog.txt)

I think this are the big points :)

slabbi commented 2 months ago

You should use https://gitforwindows.org/ From the command line pull the complete repository "git pull". Then you can do changes and push these back using the GUI (scan, stage, commit, push).

joomod commented 2 months ago

thanks I will try