search

slac-epics / epics-base

EPICS base with SLAC modifications
Other
0 stars 3 forks source link

Remove unneeded condition from myReceive to avoid message loss. #4

Closed mcb64 closed 8 months ago

mcb64 commented 1 year ago

If we timeout while a send is happening, a message will be put into threadNode by the sender but we will ignore it because status is epicsEventWaitTimeout, not epicsEventOK. The status check is unneeded and causes us to lose a message.

bhill-slac commented 8 months ago

This would be a good change to submit to the EPICS community. There could be other status values that should return -1.

mcb64 commented 8 months ago

My recollection is that newer epics bases didn't have this issue. So this was essentially patching old releases that we are still using... --Mike

From: Bruce Hill @.> Sent: Wednesday, March 20, 2024 12:52 AM To: slac-epics/epics-base @.> Cc: Browne, Michael C. @.>; Author @.> Subject: Re: [slac-epics/epics-base] Remove unneeded condition from myReceive to avoid message loss. (PR #4)

This would be a good change to submit to the EPICS community. There could be other status values that should return -1.

— Reply to this email directly, view it on GitHubhttps://github.com/slac-epics/epics-base/pull/4#issuecomment-2008972375, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH3RBOY6WEHRZYFJV76JFELYZE53JAVCNFSM6AAAAAAYPPKU3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBYHE3TEMZXGU. You are receiving this because you authored the thread.Message ID: @.***>