slac-lcls / smalldata_tools

code to facilitate production of LCLS small data files and the analysis thereof
12 stars 11 forks source link

ttCalib in smd_producer #102

Closed vespos closed 2 years ago

vespos commented 2 years ago

(re)Implement user-defined tt calibration parameters into smalldata producer. Keep only detObject related stuff into the smalldata_producer_template. This is really the only purpose of the template (keep an example of all detObjectFunc implementations). Removing the rest limits the risk of divergence and confusion between the template and the actual producers.

Adding a couple quality of life and changes as we go through the CXI implementation with Tyler

vespos commented 2 years ago

Question: Any reason we don't want to have the ttCorr to be 0 instead of np.nan when bad/wrong (see tt detector in the default det definition)? This would make it consistent with what we get out of the DAQ directly