slac-lcls / smalldata_tools

code to facilitate production of LCLS small data files and the analysis thereof
12 stars 11 forks source link

First pass script to update run tables #190

Closed mcb64 closed 5 months ago

mcb64 commented 6 months ago

This also includes some changes to the epicsarchiver module:

One important point to be discussed is that this script currently just grabs data from the archiver, and puts in the last value prior to the start of the run. If an archiver API exists to test if the PV was connected at this point, we should add a check here. If no such API exists, it would not be unreasonable to assume "old" values (for some definition of old) are no longer valid. (We might want to add these anyway... it's a point of discussion, as I said.)

mcb64 commented 5 months ago

No, it checks if you were disconnected at the start of the run, and doesn't add data if you were.

I had sent mail to Murali... what I'm doing here is not terribly efficient, and he should be able to provide a single call to give me the second data point that I need instead of having me search for it. But putting in that call could be a future PR...