slac-lcls / smalldata_tools

code to facilitate production of LCLS small data files and the analysis thereof
12 stars 11 forks source link

Bug/photon #77

Closed silkenelson closed 2 years ago

silkenelson commented 2 years ago

If no mask was passed to ROI function and the detector did not have any masks defined either, the mask was defined as a pedestal shaped array of ones. This does not behave right when the pedestal also does not exist. Now the mask will be None in this case

Many iterations of the photon code do not pass in the threshold parameter of the ImgAlgo photon algorithm. This is fixed and an ADU threshold to be applied before photonizing has been added (as some user code indicates that how they wanted to use the previously existing parameter). The original parameter has been renamed to the_fraction.